nixos/bitlbee: use purple-2 as purple_plugin_path #49440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeji
reviewed
Oct 30, 2018
| @@ -33,7 +33,7 @@ let | |||
|
|
|||
| purple_plugin_path = | |||
| lib.concatMapStringsSep ":" | |||
| (plugin: "${plugin}/lib/pidgin/") | |||
| (plugin: "${plugin}/lib/purple-2/") | |||
There was a problem hiding this comment.
Does that work for all relevant plugins? For instance, purple-matrix and purple-hangouts use lib/pidgin.
But I don't know if these are supposed to be used with bitlbee, I don't use it myself.
There was a problem hiding this comment.
well the majority of them use now purple-2, at least all I checked. I guess, for compatibility we can also include both.
Lassulus
force-pushed
the
bitlbee-purple
branch
from
b61ecb3
to
9b2121b
Compare
|
I would recommend to keep both paths to prevent breakage, especially if we want to backport this.
|
|
now both dirs are added. Tested this locally on 18.09 with the telegram plugin |
|
Thanks. Will merge later today.
|
xeji
pushed a commit
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 334dd6f)
|
backported in f4deae9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fix purple plugins in bitlbee
please backport also to 18.09
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)