lgtm

Any update on this?

@infinisil it's in beta 5 so we're waiting on a release.

Updated to Kodi v18rc5.2 and inputstream-adaptive 2.3.12; still works so far.

@sephalon https://kodi.tv/article/kodi-180 😄

lgtm, but this update will probably break a bunch of plugins that we'll need to fix afterwards

Updated to Kodi v18.0 final now. Also updated some dependencies that I previously forgot about.

inputstream.adaptive cannot be updated before xbmc/inputstream.adaptive#230 hasn't been fixed. 2.3.12 still works though.

Any chance of this getting in 19.03?

If @cpages says this is fine, I'll merge this.

However all the plugins that we have we'll need to be updated because of breakage.

From the wiki it says that most plugins should just work, and I see that just a few fail to build (some of which seem already broken anyway #25490). I think it's worth to have this in 19.03

If @cpages says this is fine, I'll merge this.

However all the plugins that we have we'll need to be updated because of breakage.

Just a heads-up that I updated all the ones that were failing to build. I can't test all of them, though, so let's hope for the best

@cpages I found an issue with inputstream-adaptive when I tried to load the Netflix plugin.

Error Contents: No module named Cryptodome.Random

Looks like python2Packages.pycryptodomex is required.

@aanderse if I read correctly, pycryptodomex is a dependency of the netflix plugin itself, not of inputstream-adaptive. But then it also lists Libwidevine as a requirement, so maybe you can open a separate issue?

@cpages I thought I had read somewhere it was a dependency of inputstream-adaptive itself, not kodi... but I can't find a reference to that now (and you aren't having this issue) so that's obviously wrong.
If this python library is a dependency and assumes the system already has it installed I guess the two options are to include with kodi itself, or make a nix package for netflix.