New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish moving all python packages -> python-modules #49434
Merged
FRidh
merged 190 commits into
NixOS:staging
from
costrouc:costrouc/refactor-move-to-python-modules-4
Oct 30, 2018
Merged
Finish moving all python packages -> python-modules #49434
FRidh
merged 190 commits into
NixOS:staging
from
costrouc:costrouc/refactor-move-to-python-modules-4
Oct 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first of all thanks a lot for yourr effort! Just FYI, |
costrouc
force-pushed
the
costrouc/refactor-move-to-python-modules-4
branch
from
October 30, 2018 17:36
74a181b
to
fa7d1d8
Compare
@Ma27 removed |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
All have been tested to build and is ready for merge.
Strictly moving package to python-modules. Did not attempt to upgrade package unless it added python 3 support or was broken. Also converted fetch... to fetchPypi to make future upgrades easier. All packages have been tested in sandbox mode to build properly.
Finally done moving all python package to python-modules! Should help with automation and merge conflicts with updating python modules.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)