Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish moving all python packages -> python-modules #49434

Merged
merged 190 commits into from Oct 30, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Oct 30, 2018

Things done

All have been tested to build and is ready for merge.

Strictly moving package to python-modules. Did not attempt to upgrade package unless it added python 3 support or was broken. Also converted fetch... to fetchPypi to make future upgrades easier. All packages have been tested in sandbox mode to build properly.

Finally done moving all python package to python-modules! Should help with automation and merge conflicts with updating python modules.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Oct 30, 2018

first of all thanks a lot for yourr effort!

Just FYI, dlib has been done recently in b7bc6e7.

@costrouc costrouc force-pushed the costrouc/refactor-move-to-python-modules-4 branch from 74a181b to fa7d1d8 Compare October 30, 2018 17:36
@costrouc
Copy link
Member Author

@Ma27 removed dlib from the PR. Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants