-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regextester: 0.1.7 -> 1.0.1 #49431
regextester: 0.1.7 -> 1.0.1 #49431
Conversation
* uses meson now * crashes on start complaining schema not installed, so I added a postInstall that compiles the schema? Fixes the problem but I'm not particularly familiar with these bits so review appreciated.
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: regextester Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: regextester Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: regextester Partial log (click to expand)
|
]; | ||
buildInputs = [ | ||
gtk3 | ||
granite | ||
gnome3.defaultIconTheme | ||
gnome3.glib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use top-level glib.
]; | ||
buildInputs = [ | ||
gtk3 | ||
glib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtk3 propagates glib and gsettings-desktop-schemas so adding is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to be explicit and include every library that the project links with – the project can stop using gtk
or gtk
can stop propagating glib
any time. (Well in the case of gtk – glib relationship, it pretty unlikely but I do not like making exceptions.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep that in mind in the future as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I meant listing in buildInputs
all the libraries declared as dependency
in meson.build
, not those dependencies that are only non-direct dependencies of the project. (Though projects sometimes forget to list some dependencies, relying on transitivity, which leads to breakages like #36468)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just gtk3 would be appropriate because meson.build
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They definitely use glib so I would pin them to the second category.
libxml2 | ||
elementary-cmake-modules | ||
vala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These apps should really use vala_0_40
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe with a comment that it is supposed to be changed to elementary.vala
once the elementary attribute set is merged.
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: regextester Partial log (click to expand)
|
]; | ||
|
||
postInstall = '' | ||
${gnome3.glib.dev}/bin/glib-compile-schemas $out/share/glib-2.0/schemas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gnome3.glib.dev
-> glib.dev
Also usually a post install script like this does this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is something that is still not resolved in meson. Some projects prefer to leave this to downstream distro hooks, see Arch, for example.
Success on x86_64-linux (full log) Attempted: regextester Partial log (click to expand)
|
Thank you for the feedback.
I may not be able to get to this for a week or so (travel),
feel free to make these changes or I'll do so when I get back.
Apologies and thanks again :).
…On Tue, 30 Oct 2018 12:34:13 +0000 (UTC), GrahamC of Borg ***@***.***> wrote:
<!--REQUEST_ID=3d29bbce-590c-4784-94fe-a8407e41ea76-->
Success on x86_64-linux [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.49431&attempt_id=b7373901-fe9a-4dcc-b5ff-ecf42ddd3fa9)
Attempted: regextester
<details><summary>Partial log (click to expand)</summary><p>
```
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/com.github.artemanufrij.regextester
shrinking RPATHs of ELF executables and libraries in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1
shrinking /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin/.com.github.artemanufrij.regextester-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1/bin
patching script interpreter paths in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1
checking for references to /build in /nix/store/08lnkn8r25m7xgf7j4m96cmrhpll4i7h-regextester-1.0.1...
```
</p></details>
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#49431 (comment) part: text/html
|
Success on aarch64-linux (full log) Attempted: regextester Partial log (click to expand)
|
My hero! :swoon:
…On Fri, 02 Nov 2018 14:30:37 -0700, worldofpeace ***@***.***> wrote:
@dtzWill Finished this up for you in #49560 🎆
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#49431 (comment) part: text/html
|
so I added a postInstall that compiles the schema?
Fixes the problem but I'm not particularly familiar
with these bits so review appreciated.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)