Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.memory_profiler: add plotting dependency, enable checks #49447

Merged
merged 1 commit into from Oct 30, 2018
Merged

pythonPackages.memory_profiler: add plotting dependency, enable checks #49447

merged 1 commit into from Oct 30, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 30, 2018 •
edited

Motivation for this change

I still had a memory_profiler update laying around, waiting to be upstreamed. Somebody else did the update by now, but I also enabled the checks (which pass) and added a dependency necessary to produce plots.

@GrahamcOfBorg build python2Packages.memory_profiler python3Packages.memory_profiler

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 30, 2018 10:30
@timokau timokau merged commit be08e69 into NixOS:master Oct 30, 2018
@timokau timokau deleted the memory_profiler-0.54.0 branch October 30, 2018 10:51
@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

@GrahamcOfBorg build python2Packages.memory_profiler python3Packages.memory_profiler

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.memory_profiler, python3Packages.memory_profiler

Partial log (click to expand)

warning: no files found matching 'mprof.bat'
writing manifest file 'memory_profiler.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x23dzkfa619979wb6cr4bad6wh7fvx7l-python2.7-memory_profiler-0.54.0
/nix/store/mhwwlm3gg6hc3lzsxkhdq0slwfvg9i2p-python3.6-memory_profiler-0.54.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.memory_profiler, python3Packages.memory_profiler

Partial log (click to expand)

warning: no files found matching 'mprof.bat'
writing manifest file 'memory_profiler.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ap4mg1d89wwmgxi1nakdaq8ircqp4c7d-python2.7-memory_profiler-0.54.0
/nix/store/dfqjq3n4rxcrpikiypq5ah8bmzlnnyw2-python3.6-memory_profiler-0.54.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.memory_profiler, python3Packages.memory_profiler

Partial log (click to expand)

warning: no files found matching 'mprof.bat'
writing manifest file 'memory_profiler.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/5ly7bl4warpf0n4sva343i4cvip7fcmq-python2.7-memory_profiler-0.54.0
/nix/store/zykp0a02gbgdshjp4xsj2gs5bqiygj0i-python3.6-memory_profiler-0.54.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg