Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cypari2: 1.3.1 -> 2.0.1 #49446

Merged
merged 1 commit into from Dec 1, 2018
Merged

pythonPackages.cypari2: 1.3.1 -> 2.0.1 #49446

merged 1 commit into from Dec 1, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 30, 2018

Motivation for this change

cypari2 upgrade. Local checks are still running, will merge once they pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 30, 2018 10:27
@timokau timokau changed the title pythonPackages.cypari2: 1.3.1 -> 2.0.0 [WIP] pythonPackages.cypari2: 1.3.1 -> 2.0.0 Oct 30, 2018
@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

Was a bit too optimistic.

@timokau timokau changed the base branch from master to python-unstable October 30, 2018 10:48
@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

This depends on the cython 0.29 upgrade, so retargeting to python-unstable.

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

@GrahamcOfBorg eval

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

a47479e broke the fribidi build, requiring a meson update.

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

The pytest update in bea4b36 broke the checkPhase of python2.pkgs.entrypoints (not python3). Apparently there was some warning added and the tests count warnings:

=================================== FAILURES ===================================
___________________________________ test_bad ___________________________________

    def test_bad():
        bad_path = [osp.join(samples_dir, 'packages3')]
    
        with warnings.catch_warnings(record=True) as w:
            group = entrypoints.get_group_named('entrypoints.test1', bad_path)
    
        assert 'bad' not in group
>       assert len(w) == 1
E       assert 2 == 1
E        +  where 2 = len([<warnings.WarningMessage object at 0x7ffff17852d0>, <warnings.WarningMessage object at 0x7ffff1766f10>])

Should be harmless.

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

Now the meson upgrade breaks systemd, this update is way more annoying than I expected.

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

Issue is systemd/systemd#9883, fixed by systemd/systemd#9885. Should probably open a separate PR for the meson upgrade.

@timokau timokau mentioned this pull request Oct 30, 2018
Merged
9 tasks
@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

Of course there already is one. This is now blocked on #46020.

@timokau timokau changed the title [WIP] pythonPackages.cypari2: 1.3.1 -> 2.0.0 pythonPackages.cypari2: 1.3.1 -> 2.0.1 Nov 26, 2018
@timokau
Copy link
Member Author

timokau commented Dec 1, 2018

Finally ready.

@GrahamcOfBorg build python2.pkgs.cypari2 python3.pkgs.cypari2

@timokau timokau changed the base branch from staging-next to master December 1, 2018 10:43
@timokau timokau merged commit d9b650f into NixOS:master Dec 1, 2018
@timokau timokau deleted the cypari-2.0.0 branch December 1, 2018 11:57
timokau added a commit to timokau/nixpkgs that referenced this pull request Dec 2, 2018
@timokau
Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (NixOS#49446)"
1c0826b 
This reverts commit d9b650f.

The update is causing segfaults. See
https://trac.sagemath.org/ticket/26442.
timokau added a commit that referenced this pull request Dec 2, 2018
@timokau
Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (#49446)" (#51414)
5f2b8de 
This reverts commit d9b650f.

The update is causing segfaults. See
https://trac.sagemath.org/ticket/26442.
@timokau timokau restored the cypari-2.0.0 branch January 11, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg