Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sympy: 1.2 -> 1.3 #49452

Merged
merged 1 commit into from Oct 30, 2018
Merged

pythonPackages.sympy: 1.2 -> 1.3 #49452

merged 1 commit into from Oct 30, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 30, 2018

Motivation for this change

sympy upgrade.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 30, 2018 12:15
@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

@GrahamcOfBorg build python2.pkgs.sympy python3.pkgs.sympy

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.sympy, python3.pkgs.sympy

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3
gzipping man pages under /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3/lib  /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3/bin
patching script interpreter paths in /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3
checking for references to /build in /nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3...
wrapping `/nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3/bin/isympy'...
/nix/store/9ni9hhac2dc76xvks6ndw1hcjf9v6h33-python2.7-sympy-1.3
/nix/store/3fbvqaxzcswfbg71v8hyzwks8lk510ga-python3.6-sympy-1.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.sympy, python3.pkgs.sympy

Partial log (click to expand)

  The script isympy is installed in '/nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed sympy-1.3
/private/tmp/nix-build-python3.6-sympy-1.3.drv-0/sympy-1.3
post-installation fixup
gzipping man pages under /nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3/lib  /nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3/bin
patching script interpreter paths in /nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3
wrapping `/nix/store/glj2vs05ilrz3mgbzx866l5qbk2z1hz8-python3.6-sympy-1.3/bin/isympy'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.sympy, python3.pkgs.sympy

Partial log (click to expand)

Successfully installed sympy-1.3
/build/sympy-1.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3
gzipping man pages under /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3/lib  /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3/bin
patching script interpreter paths in /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3
checking for references to /build in /nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3...
wrapping `/nix/store/c5wdprdrqlxj0nfzs09kfplr2g6rzz6d-python3.6-sympy-1.3/bin/isympy'...

@timokau
Copy link
Member Author

timokau commented Oct 30, 2018

Not too many rebuilds and nix-review pr passes.

@timokau timokau merged commit 835df8a into NixOS:master Oct 30, 2018
@timokau timokau deleted the sympy-1.3 branch October 30, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg