Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs-10_x to 10.13.0 #49453

Closed
wants to merge 1 commit into from

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Oct 30, 2018

Motivation for this change

Release Notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lo1tuma lo1tuma changed the title Update nodejs-10_x and make it the default Update nodejs-10_x to 10.13.0 Oct 30, 2018
@Ma27
Copy link
Member

Ma27 commented Nov 7, 2018

@GrahamcOfBorg build nodejs-10_x

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-install-checks/LICENSE
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-install-checks/index.js
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-install-checks/CHANGELOG.md
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-cache-filename/test.js
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-cache-filename/README.md
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-cache-filename/package.json
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-cache-filename/LICENSE
installing /nix/store/679yygasyzw5lz1w4s2a4j8ij94s5mb0-nodejs-10.13.0/lib/node_modules/npm/node_modules/npm-ca
builder for '/nix/store/zwrhnxbf7a9ciy59gh3qw7mnrjzjf9f1-nodejs-10.13.0.drv' failed with exit code 2
error: build of '/nix/store/zwrhnxbf7a9ciy59gh3qw7mnrjzjf9f1-nodejs-10.13.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

  clang++ -Wl,-no_pie -Wl,-search_paths_first -mmacosx-version-min=10.7 -arch x86_64 -L/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release -stdlib=libc++  -o "/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/mksnapshot" /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_base.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_init.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_libbase.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_libplatform.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_nosnapshot.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libicui18n.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_libsampler.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libicuucx.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libicudata.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libicustubdata.a /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/libv8_initializers.a -L/nix/store/v8w9k5zzfidw4ik5rjxbpf9cfvbrj9s3-zlib-1.2.11/lib -lz -L/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/lib -luv -L/nix/store/a3f3glwvv9nhk5hyxlprrb1zjwr63r3q-openssl-1.1.1/lib -lcrypto -lssl
ld: warning: object file (/nix/store/18m8lpffppmhxqhdgkgh66pvw2sc20bz-Libsystem-osx-10.11.6/lib/crt1.10.6.o) was built for newer OSX version (10.10) than being linked (10.7)
  LD_LIBRARY_PATH=/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/lib.host:/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/gypfiles; mkdir -p /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/geni; "/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/mksnapshot" --turbo_instruction_scheduling --startup_src "/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/geni/snapshot.cc"
  clang++ -o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/experimental-extras-libraries.o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen/experimental-extras-libraries.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/experimental-extras-libraries.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/extras-libraries.o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen/extras-libraries.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/extras-libraries.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/libraries.o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen/libraries.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/gen/libraries.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/deps/v8/src/setup-isolate-deserialize.o ../deps/v8/src/setup-isolate-deserialize.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/deps/v8/src/setup-isolate-deserialize.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/geni/snapshot.o /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/geni/snapshot.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj/gen  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.13.0.drv-0/node-v10.13.0/out/Release/obj.target/v8_snapshot/geni/snapshot.o.d.raw   -c
building of '/nix/store/lssbn6msnzqpwyll2h5hr3hq7whvxv4n-nodejs-10.13.0.drv' timed out after 1800 seconds
error: build of '/nix/store/lssbn6msnzqpwyll2h5hr3hq7whvxv4n-nodejs-10.13.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

       case 0xF7:
       ^~~~
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/eh-frame-x64.o ../deps/v8/src/x64/eh-frame-x64.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/eh-frame-x64.o.d.raw   -c
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/frame-constants-x64.o ../deps/v8/src/x64/frame-constants-x64.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/frame-constants-x64.o.d.raw   -c
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/interface-descriptors-x64.o ../deps/v8/src/x64/interface-descriptors-x64.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/interface-descriptors-x64.o.d.raw   -c
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/macro-assembler-x64.o ../deps/v8/src/x64/macro-assembler-x64.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/macro-assembler-x64.o.d.raw   -c
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/simulator-x64.o ../deps/v8/src/x64/simulator-x64.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/x64/simulator-x64.o.d.raw   -c
  g++ -o /build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/trap-handler/handler-inside-linux.o ../deps/v8/src/trap-handler/handler-inside-linux.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.36"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.13.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.13.0/out/Release/.deps//build/node-v10.13.0/out/Release/obj.target/v8_base/deps/v8/src/trap-handler/handler-inside-linux.o.d.raw   -c
building of '/nix/store/ils1k0r48rm6g2gprqg8hnl94ap47ay9-nodejs-10.13.0.drv' timed out after 1800 seconds
error: build of '/nix/store/ils1k0r48rm6g2gprqg8hnl94ap47ay9-nodejs-10.13.0.drv' failed

@Ma27
Copy link
Member

Ma27 commented Nov 7, 2018

So... this seems to be an equal result of OfBorg CI as in the last bump of nodejs v10 (#48186). As you seem to regularly work on keeping our nodejs packages up-to-date, do you have an idea, why this brekas aarch64? It seems as 10.12 with aarch64 builds on Hydra (although it broke the borg): https://hydra.nixos.org/job/nixpkgs/trunk/nodejs-10_x.aarch64-linux

I just compiled NodeJS 10.13 locally with sandbox enabled and it seems to work (np{x,m} as well), so at least we can be confident about darwin and linux on x86_64.

@lo1tuma
Copy link
Member Author

lo1tuma commented Nov 8, 2018

Interesting. It looks similar to the build issues with nodejs 11 on NixOS x86_64 (see #48911).

@Ma27
Copy link
Member

Ma27 commented Nov 8, 2018

Thanks a lot for the cross-link 👍

I'll see if I can reproduce something like this on my machine, maybe this helps me to find the root cause. Otherwise I'd rather wait with merging (sorry!) and ping one of the folks in meta.maintainers in nodejs.nix :)

@marsam
Copy link
Contributor

marsam commented Dec 19, 2018

nodejs v10.14.2 released https://nodejs.org/en/blog/release/v10.14.2/

@adisbladis
Copy link
Member

Superseded by #53270

@adisbladis adisbladis closed this Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants