Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpgtk: init at 5.7.4 #48270

Merged
merged 1 commit into from Nov 11, 2018
Merged

wpgtk: init at 5.7.4 #48270

merged 1 commit into from Nov 11, 2018

Conversation

Melkor333
Copy link
Contributor

Motivation for this change

It needs "programs.dconf.enabled = true" in the NixOS configuration or dconf installed and running on other distributions. Since this can't be tested in the package, I added this information in the long description. I hope it is i.O. like that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (excluding hidden wrappers)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar previously requested changes Oct 12, 2018
View reviewed changes
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/wpgtk/default.nix Outdated Show resolved Hide resolved
@Melkor333
Copy link
Contributor Author

Thank you very much for your good review! I have changed the package so that it should now be okay:

  • fixed typos
  • removed python3 and use only python36Packages now
  • removed pythonEnv and added necessary libraries to pythonPath.
    Thank you very much for pointing this out. I initially only used buildInputs which didn't work and found propagatedBuildInputs being used in another package. Both work but pythonPath is obviously the proper variable to use
  • remove unnecessary name variable

@jtojnar
Copy link
Contributor

jtojnar commented Nov 3, 2018

Could you try rebasing to fix the conflict and squashing to a single commit?

@Melkor333
Copy link
Contributor Author

Finally did it. Sorry for this delay and thanks again very much for your time.

@jtojnar jtojnar merged commit cf7e712 into NixOS:master Nov 11, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Nov 11, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Melkor333 @jtojnar @GrahamcOfBorg @Janik-Haag