Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glob093 doesnt exist #48275

Closed
wants to merge 4 commits into from
Closed

Glob093 doesnt exist #48275

wants to merge 4 commits into from

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 12, 2018

Motivation for this change
  ~/nixpkgs $ nix repl default.nix
  ~/nixpkgs $ nix repl default.nix 
   Welcome to Nix version 2.0.4. Type :? for help.

   Loading 'default.nix'...
   Added 9532 variables.

   nix-repl> haskell.packages.ghc861.Glob 
   error: attribute 'Glob_0_9_3' missing, at 
  /home/user/nixpkgs/pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix:52:10
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Just remove the line completely, Glob = super.Glob is the same as not having it at all. And make sure for this to only be a single commit

peti
peti requested changes Oct 14, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit hackage-packages.nix. Please see the comment in the very first line.

@infinisil
Copy link
Member

@peti I think the user was just a bit git confused, the only commit they intend to contribute is the "fix Glob not existing" one, which seems okay to do

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2018

Solved in 95ae256

@c0bw3b c0bw3b closed this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chessai @infinisil @c0bw3b @peti @GrahamcOfBorg