Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termbox: init at 1.1.2 #48261

Merged
merged 1 commit into from Oct 12, 2018
Merged

termbox: init at 1.1.2 #48261

merged 1 commit into from Oct 12, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Oct 12, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edude03
Copy link
Contributor

edude03 commented Oct 12, 2018

🤔 shouldn't this be in pythonXXPackages instead?

@fgaz
Copy link
Member Author

fgaz commented Oct 12, 2018

@edude03 only the build system is in python. The actual library is C

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: termbox

Partial log (click to expand)

+ symlink /nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2/nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2/lib/libtermbox.so (to libtermbox.so.1.0.0)
Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.043s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2
shrinking /nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2/nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2/lib/libtermbox.so.1.0.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2
checking for references to /build in /nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2...
/nix/store/qih1c81mabmfvdfj0aqzvrgw2ncih40v-termbox-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: termbox

Partial log (click to expand)

+ install /nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2/nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2/lib/libtermbox.so.1.0.0 (from build/src/libtermbox.so)
Waf: Leaving directory `/build/source/build'
'install' finished successfully (0.014s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2
shrinking /nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2/nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2/lib/libtermbox.so.1.0.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2
checking for references to /build in /nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2...
/nix/store/3qvgxlnxpqlzpyzgw0rwb7070r6iidgv-termbox-1.1.2

timokau
timokau reviewed Oct 12, 2018
View reviewed changes
pkgs/development/libraries/termbox/default.nix
meta = with stdenv.lib; {
description = "Library for writing text-based user interfaces";
license = licenses.mit;
homepage = "https://github.com/nsf/termbox#readme";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes around URLs are not necessary in nix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget about that >.<

timokau
timokau approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timokau timokau merged commit ef0c384 into NixOS:master Oct 12, 2018
@fgaz fgaz deleted the termbox/init branch May 11, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgaz @edude03 @GrahamcOfBorg @timokau