Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containers: Make systemd journals available from the host #47975

Merged
merged 1 commit into from Oct 17, 2018
Merged

containers: Make systemd journals available from the host #47975

merged 1 commit into from Oct 17, 2018

Conversation

aneeshusa
Copy link
Contributor

This is set by default if using the upstream systemd-nspawn@ units.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg test containers-host containers-tmpfs containers-imperative

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.containers-tmpfs, tests.containers-imperative

The following builds were skipped because they don't evaluate on aarch64-linux: tests.containers-host

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
test script finished in 52.30s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/gchmmi9hss36skvh700ys9m6g8148hc0-vm-test-run-containers-tmpfs
/nix/store/lyccb0qig9kmjbkz0k14q136bsafz791-vm-test-run-containers-imperative

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: tests.containers-tmpfs, tests.containers-imperative

The following builds were skipped because they don't evaluate on x86_64-linux: tests.containers-host

Partial log (click to expand)

cannot build derivation '/nix/store/wk56rc2fb3vh6arvnmi9pxr18kwr9nfv-nixos-test-driver-containers-tmpfs.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8jzfpwqanhyia0922vcld4adbd5caxvf-vm-test-run-containers-tmpfs.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/z74vvfwnhd2lwqzh8n3if387m8bil5sn-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ciwx2x12as8b22kjwkjcqy9fxl94xzs8-nixos-system-machine-19.03.git.e174785.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/gw1ff8l4nvvpiq26xcbbw2nrqa41v14q-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vmb2sddpjcgabi4c2q64v4dq7s8rvnw8-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/385ihkx22qh8qivfrig8vk4ml4dgnmgh-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5d55pqlj8mrs862kg2cc35jdj5xzw78w-nixos-test-driver-containers-imperative.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bp1i4zrlrcg1fss45rz9ldcfq9gywm42-vm-test-run-containers-imperative.drv': 1 dependencies couldn't be built
error: build of '/nix/store/8jzfpwqanhyia0922vcld4adbd5caxvf-vm-test-run-containers-tmpfs.drv', '/nix/store/bp1i4zrlrcg1fss45rz9ldcfq9gywm42-vm-test-run-containers-imperative.drv' failed

infinisil
infinisil approved these changes Oct 13, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test succeeds on my machine

@infinisil
Copy link
Member

Can you change the commit message to "nixos/containers: ..."? I can then merge it

@aneeshusa
nixos/containers: Make systemd journals available from the host
d85317c 
This is set by default if using the upstream systemd-nspawn@ units.
@aneeshusa aneeshusa force-pushed the make-container-journals-available-from-host branch from 36c5b32 to d85317c Compare October 16, 2018 02:56
@aneeshusa
Copy link
Contributor Author

Done.

@infinisil infinisil merged commit 8319ec3 into NixOS:master Oct 17, 2018
@aneeshusa aneeshusa deleted the make-container-journals-available-from-host branch January 7, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aneeshusa @infinisil @GrahamcOfBorg