[backport] Miniupnpd and bittorrent improvements (#46443) #47956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2039327)
(cherry picked from commit d3eff01)
(cherry picked from commit 32c63c6)
This attempts to improve stability of the test by using existing services for miniupnpd and transmission. It also uses explicit addresses for the network interfaces so that the external IP addresses are valid internet addresses (thus fixing validation problems from upnpc). Also disable eth0 from being used to transfer torrents over without that being the intention. (cherry picked from commit 276ffc5)
(cherry picked from commit 5fbc521)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: miniupnpd Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: miniupnpd Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: miniupnpd Partial log (click to expand)
|
|
👍 |
|
Hmm, not sure why the tests don't seem to have triggered? @GrahamcOfBorg test upnp bittorrent |
|
Success on x86_64-linux (full log) Attempted: tests.upnp, tests.bittorrent Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: tests.upnp, tests.bittorrent Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46443
That PR fixes a test and adds another test.
[18.09/backport-46443 9dc6bdc] miniupnpd: wrap iptables scripts to use correct PATH
Date: Sat Sep 15 15:07:27 2018 +0200
1 file changed, 14 insertions(+), 2 deletions(-)
[18.09/backport-46443 4342bdd] nixos: miniupnpd: use iptables scripts
Date: Sat Sep 15 15:08:18 2018 +0200
1 file changed, 2 insertions(+), 22 deletions(-)
[18.09/backport-46443 3ab4c76] tests: upnp: init test for upnp using miniupnpd / miniupnpc
Date: Sat Sep 15 15:09:05 2018 +0200
2 files changed, 95 insertions(+)
create mode 100644 nixos/tests/upnp.nix
[18.09/backport-46443 b453212] tests: bittorrent: improve stability
Date: Sat Sep 15 15:15:32 2018 +0200
1 file changed, 66 insertions(+), 33 deletions(-)
[18.09/backport-46443 fc8769d] tests: bittorrent: add bobvanderlinden as maintainer
Date: Sat Sep 15 15:15:50 2018 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
This PR is mainly to satisfy the requirements of testing via CI before merging.
cc @bobvanderlinden
@GrahamcOfBorg test upnp bittorrent