Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.18.0 -> 2.18.1 (CVE-2018-17456) #47925

Merged
merged 1 commit into from Oct 5, 2018
Merged

git: 2.18.0 -> 2.18.1 (CVE-2018-17456) #47925

merged 1 commit into from Oct 5, 2018

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Oct 5, 2018 •
edited

Motivation for this change

Patch CVE-2018-17456 (arbitrary command execution vulnerability on git clone --recursive)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=817, Tests=19075, 86 wallclock secs ( 9.18 usr 31.86 sys + 535.85 cusr 2935.72 csys = 3512.61 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.18.1/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.18.1/t'
make[1]: Leaving directory '/build/git-2.18.1/t'
/nix/store/9x3gqwzrhg11pcazl2wnr2qf7bklj5y9-git-2.18.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=817, Tests=19075, 204 wallclock secs ( 5.10 usr  0.84 sys + 268.96 cusr 262.64 csys = 537.54 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.18.1/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.18.1/t'
make[1]: Leaving directory '/build/git-2.18.1/t'
/nix/store/3dm45p4sgba9g8lk6pza40sl2rhnzghx-git-2.18.1

@andir andir merged commit b0b0a6c into NixOS:release-18.09 Oct 5, 2018
@edef1c edef1c deleted the git-2.18.1 branch October 6, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edef1c @GrahamcOfBorg @andir @c0bw3b