Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpdf: Drop CVE-2018-9918.patch #47935

Merged
merged 1 commit into from Oct 5, 2018
Merged

qpdf: Drop CVE-2018-9918.patch #47935

merged 1 commit into from Oct 5, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 5, 2018

Motivation for this change

This patch has been merged upstream in 8.2.1, as pointed out in #47899.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bgamari
qpdf: Drop CVE-2018-9918.patch
dc888ea 
This has been merged upstream in 8.2.1.
@bgamari bgamari mentioned this pull request Oct 5, 2018
Closed
9 tasks
@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

@GrahamcOfBorg build qpdf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpdf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1
shrinking /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/bin/qpdf
shrinking /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/bin/zlib-flate
shrinking /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/lib/libqpdf.so.21.2.1
gzipping man pages under /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/lib  /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1/bin
patching script interpreter paths in /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1
checking for references to /build in /nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1...
/nix/store/1r23acya9ivy0i7pihnkvxpc48hfiwsn-qpdf-8.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qpdf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1
shrinking /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/bin/zlib-flate
shrinking /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/bin/qpdf
shrinking /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/lib/libqpdf.so.21.2.1
gzipping man pages under /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/lib  /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1/bin
patching script interpreter paths in /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1
checking for references to /build in /nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1...
/nix/store/digg23sh8q3g5ckixakcyh9q7m5g6snv-qpdf-8.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qpdf

Partial log (click to expand)

if [ -f doc/qpdf-manual.pdf ]; then \
        cp doc/qpdf-manual.pdf /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1/share/doc/qpdf; \
fi
cp doc/*.1 /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1/lib  /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1/bin
patching script interpreter paths in /nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1
/nix/store/vyzf9xk0c8mx11cd0h5kdys83ryb0dvh-qpdf-8.2.1

@xeji xeji merged commit 58a02af into NixOS:master Oct 5, 2018
@bgamari
Copy link
Contributor Author

bgamari commented Oct 7, 2018

Can we merge this to 18.09?

xeji pushed a commit that referenced this pull request Oct 8, 2018
@bgamari @xeji
qpdf: Drop CVE-2018-9918.patch (#47935)
2fdba72 
This has been merged upstream in 8.2.1.

(cherry picked from commit 58a02af)
@xeji
Copy link
Contributor

xeji commented Oct 8, 2018

backported in 2fdba72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @xeji @GrahamcOfBorg