Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd-wait: init at 0.1+2018-10-05 #47936

Merged
merged 1 commit into from Oct 6, 2018
Merged

systemd-wait: init at 0.1+2018-10-05 #47936

merged 1 commit into from Oct 6, 2018

Conversation

benley
Copy link
Member

@benley benley commented Oct 5, 2018

Motivation for this change

This will be useful when we want to use systemd units to run graphical login sessions: systemd-wait --user window-manager.service inactive at the end of an xsession script ought to work great.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd-wait

Partial log (click to expand)

writing top-level names to systemd_wait.egg-info/top_level.txt
reading manifest file 'systemd_wait.egg-info/SOURCES.txt'
writing manifest file 'systemd_wait.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/dhswzb2j1jx1fz9kcdzsyrhd6vx0fmlz-systemd-wait-0.1+2018-10-05

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd-wait

Partial log (click to expand)

writing top-level names to systemd_wait.egg-info/top_level.txt
reading manifest file 'systemd_wait.egg-info/SOURCES.txt'
writing manifest file 'systemd_wait.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/r9ix51gkcvk56abjibsavh1dh2h971z1-systemd-wait-0.1+2018-10-05

@rycee
Copy link
Member

rycee commented Oct 6, 2018

For the graphical session I would prefer systemctl --user --wait, although it doesn't work with the current default systemd/dbus configuration.

@benley
Copy link
Member Author

benley commented Oct 6, 2018

Interesting, I didn't know about that command. In any case, even if we don't use this particular systemd-wait script in nixos sessions I would like to use it in some of my own configs.

@rycee
Copy link
Member

rycee commented Oct 6, 2018

Yes, absolutely. This seems to be a useful utility that should be available in Nixpkgs.

@rycee rycee merged commit 2f1e448 into NixOS:master Oct 6, 2018
@benley benley deleted the systemd-wait branch October 6, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @GrahamcOfBorg @rycee