Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: include icc profile validation patch #47937

Merged
merged 1 commit into from Oct 5, 2018
Merged

ghostscript: include icc profile validation patch #47937

merged 1 commit into from Oct 5, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 5, 2018

See apple/cups#5394

closes #47193, #46216

source url http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=bc3df0773fcc
contains invalid characters, which is why we don't fetchpatch.

(cherry picked from commit 2aa7506)

Motivation for this change

see #47193

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu @flokli
ghostscript: include icc profile validation patch
9a57e00 
See apple/cups#5394

closes NixOS#47193, NixOS#46216

source url
http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=bc3df0773fcc
contains invalid characters, which is why we don't fetchpatch.

(cherry picked from commit 2aa7506)
@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2018

@GrahamcOfBorg test printing

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/5366iipapa52l3wsn7c073mzxs63gj08-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 171.26s
cleaning up
killing server (pid 631)
killing client (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/blmj90v3kwbmj44b1vzwn9l9wakjsa9y-vm-test-run-printing

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/sla6f5ighhx09pickcbdvc8w6fvn7rrg-ghostscript-9.24-man
gzipping man pages under /nix/store/sla6f5ighhx09pickcbdvc8w6fvn7rrg-ghostscript-9.24-man/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sla6f5ighhx09pickcbdvc8w6fvn7rrg-ghostscript-9.24-man
checking for references to /build in /nix/store/sla6f5ighhx09pickcbdvc8w6fvn7rrg-ghostscript-9.24-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/7rvdns3cmshqv6qnkf5y3pww8fmjq2mr-ghostscript-9.24-doc
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7rvdns3cmshqv6qnkf5y3pww8fmjq2mr-ghostscript-9.24-doc
checking for references to /build in /nix/store/7rvdns3cmshqv6qnkf5y3pww8fmjq2mr-ghostscript-9.24-doc...
/nix/store/rbz7fcliq4ka63swrc76i5nz4yhxlh29-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/45vr9k6v8419v8qmz9ri5z0df5miv1vc-ghostscript-9.24/bin/ps2pdfwr: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/45vr9k6v8419v8qmz9ri5z0df5miv1vc-ghostscript-9.24/bin/ps2ps: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/45vr9k6v8419v8qmz9ri5z0df5miv1vc-ghostscript-9.24/bin/ps2ps2: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/45vr9k6v8419v8qmz9ri5z0df5miv1vc-ghostscript-9.24/bin/unix-lpr.sh: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
gzipping man pages under /nix/store/7ab8d7cradrv1d021sxbz1s2nkxz0kyl-ghostscript-9.24-man/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/7ab8d7cradrv1d021sxbz1s2nkxz0kyl-ghostscript-9.24-man
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/pqhxczdd0id3924n85bxwc0j32kh9zds-ghostscript-9.24-doc
/nix/store/45vr9k6v8419v8qmz9ri5z0df5miv1vc-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

server: running command: sync
server: exit status 0
4 out of 4 tests succeeded
test script finished in 143.59s
cleaning up
killing client (pid 600)
killing server (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5pvsdz36dlmaljs13siw4m6qikh1jgch-vm-test-run-printing

@andir
Copy link
Member

andir commented Oct 5, 2018

Since we are already rebuilding many things because of #47934 this should be fine to go in as well since it fixes the printing experience.

@andir andir merged commit 938d98e into NixOS:master Oct 5, 2018
@flokli flokli mentioned this pull request Oct 5, 2018
Merged
9 tasks
@flokli flokli deleted the ghostscript-icc-profile-validation branch October 5, 2018 23:18
@flokli flokli mentioned this pull request Oct 5, 2018
Merged
9 tasks
flokli added a commit to flokli/nixpkgs that referenced this pull request Oct 5, 2018
@flokli
ghostscript: update hash
c126aca 
I previously didn't update the hash, so was still building ghostscript-9.24
(which explained why docs were still from 9.24)

The ICC profile validation patch from NixOS#47937 is included in 9.25, so we
can strip it from the list of patches.

cc @xeji
xeji pushed a commit that referenced this pull request Oct 5, 2018
@flokli @xeji
ghostscript: update hash (#47946)
02b0836 
I previously didn't update the hash, so was still building ghostscript-9.24
(which explained why docs were still from 9.24)

The ICC profile validation patch from #47937 is included in 9.25, so we
can strip it from the list of patches.

cc @xeji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cups printing: Cannot print with HPLIP and ghostscript 9.24
4 participants
@flokli @GrahamcOfBorg @andir @eadwu