Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnulib: add a symlink from bin/gnulib-tool to gnulib-tool #47930

Merged
merged 1 commit into from Nov 18, 2018
Merged

gnulib: add a symlink from bin/gnulib-tool to gnulib-tool #47930

merged 1 commit into from Nov 18, 2018

Conversation

jamtrott
Copy link
Contributor

@jamtrott jamtrott commented Oct 5, 2018

This makes gnulib-tool available in the user's path after installing gnulib.

Motivation for this change

After installing gnulib, I would like to be able to run gnulib-tool to import gnulib packages into projects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jamtrott
gnulib: add a symlink from bin/gnulib-tool to gnulib-tool
f77fe3f 
This makes gnulib-tool available in the user's path after installing gnulib.
@matthewbauer
Copy link
Member

@GrahamcOfBorg build gnulib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnulib

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./build-aux/config.sub
Updating Autotools / GNU config script to a newer upstream version: ./build-aux/config.guess
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash
make: Nothing to be done for 'all'.
installing
/nix/store/ic2grcfp0181w9r00ixznxi5qjkr8prl-gnulib-20180226

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gnulib

Partial log (click to expand)

unpacking source archive /nix/store/8xzcy8ldivf3l7dms88h5gzfadlnrgw9-gnulib-0bec5d5
source root is gnulib-0bec5d5
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash
make: Nothing to be done for 'all'.
installing
/nix/store/fh3dggfqxsdx391nl5w6pd5j6ld4vijg-gnulib-20180226

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnulib

Partial log (click to expand)

unpacking source archive /nix/store/8xzcy8ldivf3l7dms88h5gzfadlnrgw9-gnulib-0bec5d5
source root is gnulib-0bec5d5
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash
make: Nothing to be done for 'all'.
installing
/nix/store/nxv8bfy65g1m1s86rh233xvc149pki25-gnulib-20180226

@matthewbauer matthewbauer merged commit c52a5c5 into NixOS:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamtrott @matthewbauer @GrahamcOfBorg