Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.19.0 -> 2.19.1, security fix #47928

Closed
wants to merge 1 commit into from
Closed

git: 2.19.0 -> 2.19.1, security fix #47928

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 5, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: git

Partial log (click to expand)

/nix/store/0dknj09953xbmipxw13j53ny1vjbcil8-git-2.19.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: git

Partial log (click to expand)

Files=828, Tests=19376, 230 wallclock secs ( 5.54 usr  0.92 sys + 321.29 cusr 308.73 csys = 636.48 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.19.1/t'
rm -f -r 'chainlinttmp'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.19.1/t'
make[1]: Leaving directory '/build/git-2.19.1/t'
/nix/store/lslxqfdh05x3r65sh0ds580kwsd7lfj2-git-2.19.1

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 5, 2018

Conflict with #47924

@andir andir closed this Oct 5, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: git

Partial log (click to expand)

t7505-prepare-commit-msg-hook.sh                 (Wstat: 256 Tests: 21 Failed: 1)
  Failed test:  15
  Non-zero exit status: 1
Files=828, Tests=19393, 1094 wallclock secs ( 4.84 usr  1.69 sys + 677.29 cusr 692.78 csys = 1376.60 CPU)
Result: FAIL
make[1]: *** [Makefile:52: prove] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-git-2.19.1.drv-0/git-2.19.1/t'
make: *** [Makefile:2641: test] Error 2
builder for '/nix/store/bvskg1mlz6hxgp7xs8xdsxa3amvivgmk-git-2.19.1.drv' failed with exit code 2
error: build of '/nix/store/bvskg1mlz6hxgp7xs8xdsxa3amvivgmk-git-2.19.1.drv' failed

@dtzWill dtzWill deleted the update/git-2.19.1 branch October 5, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @c0bw3b @andir