Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: add libxml2 to build #47972

Merged
merged 1 commit into from Oct 7, 2018
Merged

gdal: add libxml2 to build #47972

merged 1 commit into from Oct 7, 2018

Conversation

Hodapp87
Copy link
Contributor

@Hodapp87 Hodapp87 commented Oct 6, 2018

Motivation for this change

gdal appears to already pull in libxml2 as a transitive dependency (via libspatialite), but it is never enabled in the build. This leads to certain functionality being disabled, like the ability to read OpenStreetMap XML files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 6, 2018

@GrahamcOfBorg build gdal

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gdal

Partial log (click to expand)

shrinking /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/lib/python2.7/site-packages/osgeo/_ogr.so
shrinking /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/lib/python2.7/site-packages/osgeo/_gnm.so
shrinking /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/lib/python2.7/site-packages/osgeo/_gdal_array.so
shrinking /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/lib/libgdal.so.20.4.2
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/lib  /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/bin
patching script interpreter paths in /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2
/nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2/bin/gdal-config: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2...
/nix/store/aryf33bg24vvzf0spvd14288wyzspwx6-gdal-2.3.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gdal

Partial log (click to expand)

shrinking /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gdalsrsinfo
shrinking /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gdalinfo
shrinking /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gnmanalyse
shrinking /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gdal_rasterize
shrinking /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gdallocationinfo
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/lib  /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin
patching script interpreter paths in /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2
/nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2/bin/gdal-config: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zsfwjakhhqxps96cdywxv37p71pc0bp8-gdal-2.3.2...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: gdal

Partial log (click to expand)

               ^
               nullptr
extensions/gnm_wrap.cpp:4685:17: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]
  void *argp3 = 0 ;
                ^
                nullptr
extensions/gnm_wrap.cpp:4689:21: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]
  PyObject * obj0 = 0 ;
building of '/nix/store/0r66fji5gwv5y76p85v1mddszkjyrr7z-gdal-2.3.2.drv' timed out after 1800 seconds
error: build of '/nix/store/0r66fji5gwv5y76p85v1mddszkjyrr7z-gdal-2.3.2.drv' failed

@srhb
Copy link
Contributor

srhb commented Oct 7, 2018

Configure output says:

libxml2 support: yes

Great :)

@srhb srhb merged commit 0765000 into NixOS:master Oct 7, 2018
srhb pushed a commit that referenced this pull request Oct 7, 2018
@Hodapp87 @srhb
gdal: Add libxml2 to build
090f5e0 
(cherry picked from commit 4af38a2)
Backport of #47972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hodapp87 @xeji @GrahamcOfBorg @srhb