Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubblewrap: drop maintainership #47970

Merged
merged 1 commit into from Oct 6, 2018
Merged

bubblewrap: drop maintainership #47970

merged 1 commit into from Oct 6, 2018

Conversation

konimex
Copy link
Contributor

@konimex konimex commented Oct 6, 2018

Motivation for this change

Since I can no longer maintain and oversee this package, I hereby drop my own maintainership for this package.

However, since to my understanding (after reading CONTRIBUTING.md and the manual) a package must have at least a maintainer, I'm not sure what to do. So I opened this PR in hope for someone to see this and decide to take the helm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 6, 2018

Of course we prefer packages to have a maintainer. But it's is not a hard requirement (yet).
So this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants