Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abcde: 2.8.1 -> 2.9.2 #47958

Merged
merged 1 commit into from Oct 7, 2018
Merged

abcde: 2.8.1 -> 2.9.2 #47958

merged 1 commit into from Oct 7, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Oct 6, 2018

Instead of applying a patch and then calling sed, we just set the path to cdparanoia in the configuration file. (The system configuration file is loaded even if there is a ~/.abcde.conf.) Fixes #41789.

cc @laMudri @pSub @league @pbogdan @NeQuissimus

Will merge tomorrow unless somebody complains.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: abcde

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2
gzipping man pages under /nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2/bin
patching script interpreter paths in /nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2
/nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2/bin/abcde-musicbrainz-tool: interpreter directive changed from "/usr/bin/perl" to "/nix/store/qadiwdmbvnrkfynqh4qc1204mc0cjd2a-perl-5.28.0/bin/perl"
/nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2/bin/cddb-tool: interpreter directive changed from "/bin/bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
/nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2/bin/abcde: interpreter directive changed from "/bin/bash" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2...
/nix/store/dj13hnn9xh9sahh04jcsfshv0y84nkgj-abcde-2.9.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: abcde

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2
gzipping man pages under /nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2/bin
patching script interpreter paths in /nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2
/nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2/bin/cddb-tool: interpreter directive changed from "/bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2/bin/abcde: interpreter directive changed from "/bin/bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
/nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2/bin/abcde-musicbrainz-tool: interpreter directive changed from "/usr/bin/perl" to "/nix/store/hjn5kq7yq18z31ajq7lfd6imjwz21lh6-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2...
/nix/store/flng0ak6839p9xv9gjadld7ymb6nl55s-abcde-2.9.2

@gebner gebner merged commit 04dc2d7 into NixOS:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gebner @GrahamcOfBorg @nlewo