Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] firefox - fix i686 & mark old esr as unsupported #47957

Merged
merged 2 commits into from Oct 6, 2018
Merged

[18.09] firefox - fix i686 & mark old esr as unsupported #47957

merged 2 commits into from Oct 6, 2018

Conversation

andir
Copy link
Member

@andir andir commented Oct 6, 2018

I just realized that we are missing a few smaller changes on 18.09 that should probably still go in.

This is merely a port of changes that were done on both 18.03 and master in the past.

98e6fa3: fixes the build on i686 for Firefox.
f26df15: marks the old ESR release as unsupported. We shouldn't let users use this without them knowing what they get themselves into.

cc @samueldr @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
firefox-esr-52: mark as unsupported
f26df15 
The ESR release is no longer supported by Mozilla. We should mark it as
insecure as we did on 18.03 and master.

Originally marked as insecure on master in 0a3f070.
@andir
firefox: provide clang configure flags on i686
98e6fa3 
With the upgrade to firefox 62 clang flags are now required on i686.

(cherry picked from commit acf4a4e)
@vcunat vcunat self-assigned this Oct 6, 2018
vcunat
vcunat approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally ❤️

@vcunat vcunat merged commit 98e6fa3 into NixOS:release-18.09 Oct 6, 2018
@andir andir deleted the 18.09/firefox branch October 6, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @vcunat @GrahamcOfBorg