Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3lock-fancy: unstable-2017-12-14 -> unstable-2018-08-27 #47974

Closed
wants to merge 1 commit into from
Closed

i3lock-fancy: unstable-2017-12-14 -> unstable-2018-08-27 #47974

wants to merge 1 commit into from

Conversation

jqueiroz
Copy link
Member

@jqueiroz jqueiroz commented Oct 6, 2018

Motivation for this change
  • Updates package to a more recent version
  • Man pages are now installed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Oct 8, 2018

@GrahamcOfBorg build i3lock-fancy

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i3lock-fancy

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd
gzipping man pages under /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/bin
patching script interpreter paths in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd
/nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/bin/i3lock-fancy: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd...
/nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd

@xeji
Copy link
Contributor

xeji commented Oct 12, 2018

@GrahamcOfBorg build i3lock-fancy

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i3lock-fancy

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27
gzipping man pages under /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/bin
patching script interpreter paths in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27
/nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/bin/i3lock-fancy: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27...
/nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27

@jqueiroz
Copy link
Member Author

Just noticed that 'postInstall' was not getting invoked as 'installPhase' is specified, so I replaced it with 'postFixup'.

ryantm
ryantm requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict

@ryantm
Copy link
Member

ryantm commented Feb 25, 2019

Never mind, it's already on a later version than this entirely. Closing...

@ryantm ryantm closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

@andir andir andir left review comments

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jqueiroz @srhb @GrahamcOfBorg @xeji @ryantm @andir