zstd: 1.3.5 -> 1.3.6 #47965

dywedir · 2018-10-06T11:06:16Z

v1.3.6 "Database Edition"

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

cc @orivej

GrahamcOfBorg · 2018-10-06T11:22:15Z

Success on aarch64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/bin/zstd
shrinking /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/lib/libzstd.so.1.3.6
gzipping man pages under /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/lib  /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6
/nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6...
/nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6

GrahamcOfBorg · 2018-10-06T11:23:55Z

Success on x86_64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/lib/libzstd.so.1.3.6
shrinking /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/bin/zstd
gzipping man pages under /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/lib  /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6
/nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6...
/nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6

xeji · 2018-10-12T21:18:08Z

@GrahamcOfBorg build zstd borgbackup

GrahamcOfBorg · 2018-10-12T21:19:43Z

Success on x86_64-darwin (full log)

Attempted: zstd, borgbackup

Partial log (click to expand)

make: Leaving directory '/private/tmp/nix-build-borgbackup-1.1.7.drv-0/borgbackup-1.1.7/docs'
post-installation fixup
gzipping man pages under /nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7/lib  /nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7/bin
patching script interpreter paths in /nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7
wrapping `/nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7/bin/borg'...
wrapping `/nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7/bin/borgfs'...
/nix/store/ydnzkhfk5p9wizh6gx0h1ld7cp6l380l-zstd-1.3.6
/nix/store/0b2pxd46kwwzbdmgayym2jm77360zqky-borgbackup-1.1.7

GrahamcOfBorg · 2018-10-12T21:20:08Z

Success on x86_64-linux (full log)

Attempted: zstd, borgbackup

Partial log (click to expand)

shrinking /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/lib/python3.6/site-packages/borg/crypto/low_level.cpython-36m-x86_64-linux-gnu.so
gzipping man pages under /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/lib  /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/bin
patching script interpreter paths in /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7
checking for references to /build in /nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7...
wrapping `/nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/bin/borg'...
wrapping `/nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7/bin/borgfs'...
/nix/store/swwgkq0fi02qpx2n2cyj2cfv93lrfngm-zstd-1.3.6
/nix/store/1iy8082ziyj62acig6n4h6kskygapd6i-borgbackup-1.1.7

GrahamcOfBorg · 2018-10-12T21:21:38Z

Success on aarch64-linux (full log)

Attempted: zstd, borgbackup

Partial log (click to expand)

shrinking /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/lib/python3.6/site-packages/borg/item.cpython-36m-aarch64-linux-gnu.so
gzipping man pages under /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/lib  /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/bin
patching script interpreter paths in /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7
checking for references to /build in /nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7...
wrapping `/nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/bin/borgfs'...
wrapping `/nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7/bin/borg'...
/nix/store/3m2n1nfcxq51r4n61akgv3sbav9dw5k4-zstd-1.3.6
/nix/store/z7v1czmm43qws120xl91bl1m4v77krf5-borgbackup-1.1.7

pkgs/tools/compression/zstd/default.nix

GrahamcOfBorg · 2018-10-12T22:12:15Z

Success on x86_64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstd
shrinking /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/lib/libzstd.so.1.3.6
gzipping man pages under /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/lib  /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6...
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6

GrahamcOfBorg · 2018-10-12T22:12:53Z

Success on aarch64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/bin/zstd
shrinking /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/lib/libzstd.so.1.3.6
gzipping man pages under /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/lib  /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6
/nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6...
/nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6

xeji · 2018-10-12T22:39:59Z

let's check darwin again
@GrahamcOfBorg build zstd

GrahamcOfBorg · 2018-10-12T22:40:15Z

Success on aarch64-linux (full log)

Attempted: zstd

Partial log (click to expand)

/nix/store/v6lhqkg15rgwhs438igwxx499fs3lcg7-zstd-1.3.6

GrahamcOfBorg · 2018-10-12T22:40:56Z

Failure on x86_64-darwin (full log)

Attempted: zstd

Partial log (click to expand)

--rm    : remove source file(s) after successful de/compression
 -k     : preserve source file(s) (default)
 -h/-H  : display help/long help and exit
roundTripTest: ./datagen -g512K  |  ../programs/zstd -v |  ../programs/zstd -d
./playTests.sh: line 24: md5: command not found
make[1]: *** [Makefile:335: test-zstd] Error 127
make[1]: Leaving directory '/private/tmp/nix-build-zstd-1.3.6.drv-0/source/tests'
make: *** [Makefile:73: shortest] Error 2
builder for '/nix/store/21lknfx4hlvavlxrs2cby179x0dqdgmk-zstd-1.3.6.drv' failed with exit code 2
error: build of '/nix/store/21lknfx4hlvavlxrs2cby179x0dqdgmk-zstd-1.3.6.drv' failed

xeji · 2018-10-12T22:44:31Z

Looks like darwin needs extra checkInputs.

GrahamcOfBorg · 2018-10-12T22:44:35Z

Success on x86_64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/lib/libzstd.so.1.3.6
shrinking /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstd
gzipping man pages under /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/lib  /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6...
/nix/store/8ws99jy5d38ga58vhqf9adfckqdha8wg-zstd-1.3.6

dywedir · 2018-10-13T19:58:58Z

Looks like darwin needs extra checkInputs.

Should we use md5sum from coreutils instead of md5 (which i don't know how to get)?

xeji · 2018-10-13T20:04:10Z

I don't really know, don't use Macs at all. md5sum sounds worth trying. But if you don't want to spend time on this, doCheck = !stdenv.isDarwin; would also be ok.

GrahamcOfBorg · 2018-10-14T08:39:42Z

Success on x86_64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstd
shrinking /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/lib/libzstd.so.1.3.6
gzipping man pages under /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/lib  /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6...
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6

GrahamcOfBorg · 2018-10-14T08:40:22Z

Success on aarch64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/bin/zstd
shrinking /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/lib/libzstd.so.1.3.6
gzipping man pages under /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/lib  /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6
/nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6...
/nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6

xeji · 2018-10-14T13:52:03Z

Darwin build didn't start, try again
@GrahamcOfBorg build zstd

GrahamcOfBorg · 2018-10-14T13:52:19Z

Success on aarch64-linux (full log)

Attempted: zstd

Partial log (click to expand)

/nix/store/s0cmb15k11r3j33jnfw23a3llgmxikka-zstd-1.3.6

GrahamcOfBorg · 2018-10-14T13:53:16Z

Success on x86_64-darwin (full log)

Attempted: zstd

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-zstd-1.3.6.drv-0/source/programs'
post-installation fixup
gzipping man pages under /nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/share/man/
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/lib  /nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6
/nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/frkmk9zf3vdkdbh05hlhln8j17srj8fx-bash-4.4-p23/bin/sh"
/nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/frkmk9zf3vdkdbh05hlhln8j17srj8fx-bash-4.4-p23/bin/sh"
/nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6/lib/libzstd.1.3.6.dylib: fixing dylib
/nix/store/nc6qjnxic5ak40cyb8a3nzmd7njp96b7-zstd-1.3.6

GrahamcOfBorg · 2018-10-14T13:53:33Z

Success on x86_64-linux (full log)

Attempted: zstd

Partial log (click to expand)

shrinking /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/lib/libzstd.so.1.3.6
shrinking /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstd
gzipping man pages under /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/lib  /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin
patching script interpreter paths in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstdgrep: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6/bin/zstdless: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6...
/nix/store/pp25zdr2yv98si7qaspf7qavld5306p3-zstd-1.3.6

xeji · 2018-10-14T13:54:19Z

LGTM, thank you!

veprbl · 2018-10-19T12:10:18Z

This broke arrow-cpp build ("compression-test" fails).

"compression-test" fails when built against zstd 1.3.6 Fixes: c8f7188 ('zstd: 1.3.5 -> 1.3.6 (NixOS#47965)') Fixes: NixOS#47965

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Oct 6, 2018

xeji reviewed Oct 12, 2018

View reviewed changes

pkgs/tools/compression/zstd/default.nix Show resolved Hide resolved

dywedir force-pushed the zstd branch from fae2f77 to 52c3fd9 Compare October 12, 2018 21:54

xeji mentioned this pull request Oct 14, 2018

zstd: 1.3.5 -> 1.3.6 #48341

Closed

zstd: 1.3.5 -> 1.3.6

a03102c

dywedir force-pushed the zstd branch from 52c3fd9 to a03102c Compare October 14, 2018 08:22

xeji merged commit c8f7188 into NixOS:master Oct 14, 2018

dywedir deleted the zstd branch October 14, 2018 14:13

veprbl added a commit to veprbl/nixpkgs that referenced this pull request Oct 22, 2018

arrow-cpp: disable zstd

63d123f

"compression-test" fails when built against zstd 1.3.6 Fixes: c8f7188 ('zstd: 1.3.5 -> 1.3.6 (NixOS#47965)') Fixes: NixOS#47965

veprbl mentioned this pull request Oct 22, 2018

arrow-cpp: disable zstd #48833

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zstd: 1.3.5 -> 1.3.6 #47965

zstd: 1.3.5 -> 1.3.6 #47965

dywedir commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

dywedir commented Oct 13, 2018

xeji commented Oct 13, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

xeji commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

xeji commented Oct 14, 2018

veprbl commented Oct 19, 2018 •

edited

zstd: 1.3.5 -> 1.3.6 #47965

zstd: 1.3.5 -> 1.3.6 #47965

Conversation

dywedir commented Oct 6, 2018

Things done

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

xeji commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

dywedir commented Oct 13, 2018

xeji commented Oct 13, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

xeji commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

xeji commented Oct 14, 2018

veprbl commented Oct 19, 2018 • edited

veprbl commented Oct 19, 2018 •

edited