Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percona-toolkit: 3.0.11 -> 3.0.12 #47963

Merged
merged 2 commits into from Nov 1, 2018
Merged

percona-toolkit: 3.0.11 -> 3.0.12 #47963

merged 2 commits into from Nov 1, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 6, 2018 •
edited

Motivation for this change

Update percona-toolkit to ver 3.0.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Oct 6, 2018
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated
src = fetchFromGitHub {
owner = "percona";
repo = "percona-toolkit";
rev = "6e5c5c5e6db0a32c6951c8f798c4547539cdab87";
sha256 = "18wxvp7psqrx0zdvg47azrals572hv9fx1s3p0q65s87lnk3q63l";
rev = "e3a693afcf30f43bdacd381c9aba191772f62b96";
Copy link
Contributor

@jtojnar jtojnar Oct 6, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the git tag name here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variant with rev = "release-3.0.12"; not worked - downloaded latest source - master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag name i just the version: https://github.com/percona/percona-toolkit/releases/tag/3.0.12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worked. If rev = "3.0.11" downloaded latest version - 3.0.12

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 1, 2018

@GrahamcOfBorg build perlPackages.PerconaToolkit

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: perlPackages.PerconaToolkit

Partial log (click to expand)

Installing /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/bin/pt-ioprofile
Installing /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/bin/pt-deadlock-logger
Installing /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/bin/pt-fifo-split
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12
gzipping man pages under /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/lib  /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12/bin
patching script interpreter paths in /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12
checking for references to /build in /nix/store/58jblb5b6p2ncmlw7gd969kgwz49fl6a-perl5.28.0-Percona-Toolkit-3.0.12...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: perlPackages.PerconaToolkit

Partial log (click to expand)

Installing /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12/bin/pt-archiver
Installing /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12/bin/pt-align
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12
gzipping man pages under /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12/lib  /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12/bin
patching script interpreter paths in /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12
checking for references to /build in /nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12...
/nix/store/avm75h4rpb6mkj9qlrian67qp7s9c4cn-perl5.28.0-Percona-Toolkit-3.0.12

@c0bw3b c0bw3b merged commit 99b4045 into NixOS:master Nov 1, 2018
@Izorkin Izorkin deleted the percona-toolkit branch November 2, 2018 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @c0bw3b @GrahamcOfBorg @jtojnar