kind: init at 2ae73f8e #47967
Merged
kind: init at 2ae73f8e #47967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: kind Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kind Partial log (click to expand)
|
nlewo
requested changes
Oct 12, 2018
| goPackagePath = "sigs.k8s.io/kind"; | ||
| excludedPackages = "images/base/entrypoint"; | ||
|
|
||
| outputs = [ "bin" "out" ]; |
| @@ -0,0 +1,28 @@ | |||
| { stdenv, lib, buildGoPackage, fetchFromGitHub }: | |||
|
|
||
| buildGoPackage rec { | ||
| name = "kind-${version}"; | ||
| version = "20181003-${stdenv.lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
According to the manual, the date format is YYYY-MM-DD.
There was a problem hiding this comment.
So it is 20181003 = 2018 October 3, the day of referenced commit
There was a problem hiding this comment.
Hmm, not sure to understand:/
In fact, I was talking about missing dashes: s/20181003/2018-10-03.
Also, I think the date is more the date of the day you are writing the package since the goal is to have an ordered package name. But in this PR, 10-03 is fine.
There was a problem hiding this comment.
Ok i understand, i fixed it.
| meta = { | ||
| description = "Kubernetes IN Docker - local clusters for testing Kubernetes"; | ||
| homepage = https://github.com/kubernetes-sigs/kind; | ||
| maintainers = with stdenv.lib.maintainers; [ offline ]; |
There was a problem hiding this comment.
Could be shortened to with maintainers...
offlinehacker
force-pushed
the
pkgs/kind/init
branch
2 times, most recently
from
6d140f5
to
e2376d5
Compare
|
I have fixed other things, except for one thing noted above, thanks! |
|
Success on aarch64-linux (full log) Attempted: kind Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kind Partial log (click to expand)
|
offlinehacker
force-pushed
the
pkgs/kind/init
branch
from
e2376d5
to
6124447
Compare
|
Success on aarch64-linux (full log) Attempted: kind Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kind Partial log (click to expand)
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)