Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: update hash #47946

Merged
merged 1 commit into from Oct 5, 2018
Merged

ghostscript: update hash #47946

merged 1 commit into from Oct 5, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 5, 2018 •
edited

I previously didn't update the hash, so was still building ghostscript-9.24
(which explained why docs were still from 9.24)

The ICC profile validation patch from #47937 is included in 9.25, so we
can strip it from the list of patches.

cc @xeji

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli flokli mentioned this pull request Oct 5, 2018
Merged
9 tasks
@flokli
ghostscript: update hash
c126aca 
I previously didn't update the hash, so was still building ghostscript-9.24
(which explained why docs were still from 9.24)

The ICC profile validation patch from NixOS#47937 is included in 9.25, so we
can strip it from the list of patches.

cc @xeji
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

server: running command: sync
server: exit status 0
4 out of 4 tests succeeded
test script finished in 147.01s
cleaning up
killing client (pid 597)
killing server (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/m8wkr04n2zcyr0n5bb4bxwp84lrnjgqj-vm-test-run-printing

@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2018

@GrahamcOfBorg test printing

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/h560lzxdqijjjkc6sbqjxg1vvhfx6p7n-ghostscript-9.25

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

server: running command: sync
server: exit status 0
4 out of 4 tests succeeded
test script finished in 201.29s
cleaning up
killing client (pid 631)
killing server (pid 644)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/rwkyr7yaciw2d3f53mncwswcv5zsiz7p-vm-test-run-printing

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 245.59s
cleaning up
killing server (pid 631)
killing client (pid 644)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5nrps7i3hqypm382c5in6plxxn6d2km1-vm-test-run-printing

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/h560lzxdqijjjkc6sbqjxg1vvhfx6p7n-ghostscript-9.25

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/sgpwrqdaa22p1vh9hbxad1cb3lha9c8z-ghostscript-9.25

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/vv68ia0dscwvqhgxfv7dfgslykgmj0rr-ghostscript-9.25/bin/ps2pdfwr: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/vv68ia0dscwvqhgxfv7dfgslykgmj0rr-ghostscript-9.25/bin/ps2ps: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/vv68ia0dscwvqhgxfv7dfgslykgmj0rr-ghostscript-9.25/bin/ps2ps2: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/vv68ia0dscwvqhgxfv7dfgslykgmj0rr-ghostscript-9.25/bin/unix-lpr.sh: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
gzipping man pages under /nix/store/hmcc7f5xcds7bfc95zzwhykmw9cwf620-ghostscript-9.25-man/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/hmcc7f5xcds7bfc95zzwhykmw9cwf620-ghostscript-9.25-man
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/yz219327kzj3546jym2f5v219r9cjy7b-ghostscript-9.25-doc
/nix/store/vv68ia0dscwvqhgxfv7dfgslykgmj0rr-ghostscript-9.25

@xeji xeji merged commit 02b0836 into NixOS:master Oct 5, 2018
@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

For backporting, please make a new PR based on 18.09 so we have a clean version bump in one commit. It doesn't make much sense to cherry-pick this and the two other related PRs...

@flokli flokli deleted the ghostscript-9.25 branch October 6, 2018 00:01
@flokli flokli mentioned this pull request Oct 6, 2018
Merged
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 165.34s
cleaning up
killing server (pid 597)
killing client (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/jmlwh4f502b5h44jqgm2h73i7l3ys2q9-vm-test-run-printing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji