Skip to content
This repository has been archived by the owner on Sep 1, 2019. It is now read-only.

PRQ merge messages are duplicated #7

Closed
LordAro opened this issue Sep 16, 2018 · 5 comments
Closed

PRQ merge messages are duplicated #7

LordAro opened this issue Sep 16, 2018 · 5 comments

Comments

@LordAro
Copy link
Member

LordAro commented Sep 16, 2018 •
edited 

10:36:27 < DorpsGek_II> [OpenTTD/OpenTTD] sj26 merged pull request #6909: Add BACKSPACE as a mappable hotkey https://github.com/OpenTTD/OpenTTD/pull/6909
10:36:27 < DorpsGek_II> [OpenTTD/OpenTTD] michicc pushed 1 commits to master:
10:36:27 < DorpsGek_II>   - Add: BACKSPACE can be mapped as a hotkey (by sj26)
10:36:28 < DorpsGek_II> https://github.com/OpenTTD/OpenTTD/commit/1a73c3983863

Not sure how feasible this is, given the information received from GitHub, but these messages are largely redundant, and it'd be nice if they could be deduplicated (probably by removing the commit, rather than the merge?)
@glx22
Copy link

glx22 commented Sep 16, 2018

It's not really a duplicate, just two different sources. I think it's not possible for the bot to know they are related.

@LordAro
Copy link
Member Author

LordAro commented Sep 16, 2018

Yeah, hence the "not sure how feasible this is" :)
GitHub webinterface links commits to pull requests, I figured there might be something in the JSON API that does the same thing

@LordAro
Copy link
Member Author

LordAro commented Oct 6, 2018

Alternatively, since no one should be pushing directory to master anyway, perhaps those messages could be suppressed?

@TrueBrain TrueBrain mentioned this issue Oct 6, 2018
Closed
@TrueBrain
Copy link
Member

Issue in OpenTTD/DorpsGek-github#13

@TrueBrain
Copy link
Member

TrueBrain commented Oct 6, 2018 •
edited

I went for the: if a push follows a PR with the same sha, ignore the push. Time will tell if that was a good idea :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrueBrain @glx22 @LordAro