Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: 9.24 -> 9.25 #47934

Merged
merged 1 commit into from Oct 5, 2018
Merged

ghostscript: 9.24 -> 9.25 #47934

merged 1 commit into from Oct 5, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 5, 2018 •
edited

Changelog:

This release fixes problems with argument handling, some unintended results of the security fixes to the SAFER file access restrictions (specifically accessing ICC profile files), and some additional security issues over the recent 9.24 release.

Note: The ps2epsi utility does not, and cannot call Ghostscript with the -dSAFER command line option. It should never be called with input from untrusted sources.

Security issues have been the primary focus of this release, including solving several (well publicised) real and potential exploits.
PLEASE NOTE: We strongly urge users to upgrade to this latest release to avoid these issues.

As well as Ghostscript itself, jbig2dec has had a significant amount of work improving its robustness in the face of out specification files.

IMPORTANT: We are in the process of forking LittleCMS. LCMS2 is not thread safe, and cannot be made thread safe without breaking the ABI. Our fork will be thread safe, and include performance enhancements (these changes have all be been offered and rejected upstream). We will maintain compatibility between Ghostscript and LCMS2 for a time, but not in perpetuity. Our fork will be available as its own package separately from Ghostscript (and MuPDF).

The usual round of bug fixes, compatibility changes, and incremental improvements.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli
ghostscript: 9.24 -> 9.25
5b77b0d 
Highlights in this release include:

This release fixes problems with argument handling, some unintended results of the security fixes to the SAFER file access restrictions (specifically accessing ICC profile files), and some additional security issues over the recent 9.24 release.

CVE-2018-16802
CVE-2018-17183

Note: The ps2epsi utility does not, and cannot call Ghostscript with the -dSAFER command line option. It should never be called with input from untrusted sources.

Security issues have been the primary focus of this release, including solving several (well publicised) real and potential exploits.
PLEASE NOTE: We strongly urge users to upgrade to this latest release to avoid these issues.

As well as Ghostscript itself, jbig2dec has had a significant amount of work improving its robustness in the face of out specification files.

IMPORTANT: We are in the process of forking LittleCMS. LCMS2 is not thread safe, and cannot be made thread safe without breaking the ABI. Our fork will be thread safe, and include performance enhancements (these changes have all be been offered and rejected upstream). We will maintain compatibility between Ghostscript and LCMS2 for a time, but not in perpetuity. Our fork will be available as its own package separately from Ghostscript (and MuPDF).

The usual round of bug fixes, compatibility changes, and incremental improvements.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ddfpkbzlk2n0nad8n1rqwm18m4dg0jld-ghostscript-9.25-man
gzipping man pages under /nix/store/ddfpkbzlk2n0nad8n1rqwm18m4dg0jld-ghostscript-9.25-man/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ddfpkbzlk2n0nad8n1rqwm18m4dg0jld-ghostscript-9.25-man
checking for references to /build in /nix/store/ddfpkbzlk2n0nad8n1rqwm18m4dg0jld-ghostscript-9.25-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/5mrvrh4v80gwgvdm0ph4l52ly9z4ajnk-ghostscript-9.25-doc
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5mrvrh4v80gwgvdm0ph4l52ly9z4ajnk-ghostscript-9.25-doc
checking for references to /build in /nix/store/5mrvrh4v80gwgvdm0ph4l52ly9z4ajnk-ghostscript-9.25-doc...
/nix/store/l2ayh1jaijn4mgwgskjyfdardrmvwg1j-ghostscript-9.25

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/qpnbf27272ai5bxcwhgqlyhbbb8c12j0-ghostscript-9.25-man
gzipping man pages under /nix/store/qpnbf27272ai5bxcwhgqlyhbbb8c12j0-ghostscript-9.25-man/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qpnbf27272ai5bxcwhgqlyhbbb8c12j0-ghostscript-9.25-man
checking for references to /build in /nix/store/qpnbf27272ai5bxcwhgqlyhbbb8c12j0-ghostscript-9.25-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/bcv3wx60chx4h7hm38f0plvbf2yrksx5-ghostscript-9.25-doc
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/bcv3wx60chx4h7hm38f0plvbf2yrksx5-ghostscript-9.25-doc
checking for references to /build in /nix/store/bcv3wx60chx4h7hm38f0plvbf2yrksx5-ghostscript-9.25-doc...
/nix/store/rn30qcdmhj0d0mv34xci6gcmkbhzsbs9-ghostscript-9.25

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/zafaswqi6l7x8bpv4cpxi2xchxc152yf-ghostscript-9.25/bin/ps2pdfwr: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/zafaswqi6l7x8bpv4cpxi2xchxc152yf-ghostscript-9.25/bin/ps2ps: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/zafaswqi6l7x8bpv4cpxi2xchxc152yf-ghostscript-9.25/bin/ps2ps2: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/zafaswqi6l7x8bpv4cpxi2xchxc152yf-ghostscript-9.25/bin/unix-lpr.sh: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
gzipping man pages under /nix/store/xrjhcpmj5mxf1z4g5c387mrf9pgxmhwg-ghostscript-9.25-man/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/xrjhcpmj5mxf1z4g5c387mrf9pgxmhwg-ghostscript-9.25-man
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/4sv8y87vxmd65s6n88kkzg9x4f0zpafl-ghostscript-9.25-doc
/nix/store/zafaswqi6l7x8bpv4cpxi2xchxc152yf-ghostscript-9.25

@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2018

@GrahamcOfBorg test printing

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 143.53s
cleaning up
killing server (pid 600)
killing client (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/slyasmjjx8xf7plkp8cwxjjygzdgicxm-vm-test-run-printing

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.printing

Partial log (click to expand)

client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 232.37s
cleaning up
killing server (pid 631)
killing client (pid 644)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/0mbg993764hdxwrzw408km26lcq03ani-vm-test-run-printing

@xeji xeji merged commit 3f65f10 into NixOS:master Oct 5, 2018
@andir andir mentioned this pull request Oct 5, 2018
Merged
9 tasks
@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2018

@xeji thanks! can you take care of backporting this (and maybe #47937 as well) to 18.03 and 18.09?

@flokli flokli deleted the ghostscript-9.25 branch October 5, 2018 22:48
@xeji
Copy link
Contributor

xeji commented Oct 5, 2018 •
edited

@flokli oops, when backporting I realized that I missed something: you didn't update the sha512 (maybe that's why the docs are still in the 9.24 folder). Please have a look.

@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2018 •
edited

sorry, my bad. PR fixing this is at #47946.

@flokli flokli mentioned this pull request Oct 6, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji