Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autobahn: 18.8.2 -> 18.9.2, txaio: 18.7.1 -> 18.8.1 #48626

Merged
merged 2 commits into from Oct 28, 2018
Merged

autobahn: 18.8.2 -> 18.9.2, txaio: 18.7.1 -> 18.8.1 #48626

merged 2 commits into from Oct 28, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 17, 2018

Motivation for this change

I'm using the newer versions without problems elsewhere. The newer autobahn depends on a newer txaio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ivan ivan requested a review from FRidh as a code owner October 17, 2018 13:38
@FRidh FRidh self-assigned this Oct 17, 2018
@ivan ivan changed the title autobahn: 18.8.1 -> 18.9.2, txaio: 18.7.1 -> 18.8.1 autobahn: 18.8.2 -> 18.9.2, txaio: 18.7.1 -> 18.8.1 Oct 21, 2018
@srhb
Copy link
Contributor

srhb commented Oct 22, 2018

@GrahamcOfBorg build pythonPackages.txaio pythonPackages.autobahn

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.txaio, pythonPackages.autobahn

Partial log (click to expand)

........                                                                 [ 84%]
../../nix/store/75vkp4zc5qap2cwl21k72h61yb6dkm6b-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket.py . [ 84%]
......                                                                   [ 87%]
../../nix/store/75vkp4zc5qap2cwl21k72h61yb6dkm6b-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket_url.py . [ 87%]
............................                                             [100%]

==================== 197 passed, 33 skipped in 2.67 seconds ====================
pytestcachePhase
/nix/store/gsn019xqsqq6hbg798z89i5bgqxh12qn-python2.7-txaio-18.8.1
/nix/store/75vkp4zc5qap2cwl21k72h61yb6dkm6b-python2.7-autobahn-18.9.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.txaio, pythonPackages.autobahn

Partial log (click to expand)

........                                                                 [ 84%]
../../nix/store/wirfdhs6ymlhip92vcby7aiixlfk8jmw-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket.py . [ 84%]
......                                                                   [ 87%]
../../nix/store/wirfdhs6ymlhip92vcby7aiixlfk8jmw-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket_url.py . [ 87%]
............................                                             [100%]

==================== 197 passed, 33 skipped in 4.83 seconds ====================
pytestcachePhase
/nix/store/jz92g2x7g53adf5w501q6yz43518vyx1-python2.7-txaio-18.8.1
/nix/store/wirfdhs6ymlhip92vcby7aiixlfk8jmw-python2.7-autobahn-18.9.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.txaio, pythonPackages.autobahn

Partial log (click to expand)

........                                                                 [ 84%]
../../../../nix/store/g2wwn5602xgzby9mpjw43x0ygipigkr5-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket.py . [ 84%]
......                                                                   [ 87%]
../../../../nix/store/g2wwn5602xgzby9mpjw43x0ygipigkr5-python2.7-autobahn-18.9.2/lib/python2.7/site-packages/autobahn/websocket/test/test_websocket_url.py . [ 87%]
............................                                             [100%]

==================== 197 passed, 33 skipped in 1.50 seconds ====================
pytestcachePhase
/nix/store/26c31bk1hp127i7dv9adj7j908qy87c0-python2.7-txaio-18.8.1
/nix/store/g2wwn5602xgzby9mpjw43x0ygipigkr5-python2.7-autobahn-18.9.2

@c0bw3b c0bw3b mentioned this pull request Oct 22, 2018
Closed
9 tasks
@c0bw3b c0bw3b merged commit 0a7f6ed into NixOS:master Oct 28, 2018
@FRidh
Copy link
Member

FRidh commented Oct 28, 2018

@c0bw3b Updates are already in staging. Please revert.

@c0bw3b c0bw3b mentioned this pull request Oct 28, 2018
Merged
@worldofpeace worldofpeace mentioned this pull request Nov 2, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ivan @srhb @GrahamcOfBorg @FRidh @roberth @c0bw3b