New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor another ~100 package from python-packages.nix -> python-modules #48633
Refactor another ~100 package from python-packages.nix -> python-modules #48633
Conversation
Sorry, I broke this by splitting slixmpp in #48545 |
e08ab90 should be squashed |
added pypifetch
0b053e7
to
d627cbc
Compare
@lheckemann no worries I will rebase it. I appreciate you letting me know. @FRidh my git fu is not quite good enough and I was being lazy when I made those commits. I will learn how to properly split that commit and merge into the appropriate commit. |
b463f57
to
219bd0f
Compare
Good job. |
25 more packages -> python-modules. All tested. |
@costrouc Thank you for this work! @FRidh is encouraging me to start updating Python packages semi-automatically with r-ryantm/nixpkgs-update and it cannot update the packages in python-modules.nix (because it won't update things in a file with multiple fetchers), so this work you are doing should help keep Python packages more up to date! |
You are welcome! I was aware of your bot and someone told me that it could only work with |
The good news is that soon (next few years) python projects will start declaring their dependencies in a static file |
pyproject.toml will probably still need some time to establish. At the moment I don't see how c-extension can be build using this. |
As far as I know, nixpkgs-update doesn't need the derivation to use |
@ryantm what |
@costrouc As long as the fetcher is written in some way that it gets modified by changing the version string somewhere in the file, and the hash for it is somewhere in the file, and As for what to do for python things, I want to defer to @FRidh. I'm not familiar with the Python ecosystem. |
|
Things done
All have been tested to build and is ready for merge
Strictly moving package to python-modules. Did not attempt to upgrade package unless it added python 3 support or was broken. Also converted fetch... to fetchPypi to make future upgrades easier. All packages have been tested in sandbox mode to build properly.
As of the last edit there are ~332 remaining packages to move.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)