Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/wrappers: remove outdated upgrade code #48618

Merged
merged 1 commit into from Oct 21, 2018
Merged

nixos/wrappers: remove outdated upgrade code #48618

merged 1 commit into from Oct 21, 2018

Conversation

lheckemann
Copy link
Member

Motivation for this change

As mentioned in the code comments themselves, this was only necessary
for 16.09 -> 17.03 and as such is obsolete.

cc @globin author of the code and corresponding comments

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lheckemann
nixos/wrappers: remove outdated upgrade code
843f681 
As mentioned in the code comments themselves, this was only necessary
for 16.09 -> 17.03 and as such is obsolete.
@lheckemann
Copy link
Member Author

@GrahamcOfBorg test sudo

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.sudo

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
10 out of 10 tests succeeded
test script finished in 22.42s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/l0qricjm2fv7lw0ccjrhgil1yr0ra6kz-vm-test-run-sudo

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.sudo

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
10 out of 10 tests succeeded
test script finished in 12.81s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i2iqmlk91pkjqrj649l5csxz9pllxxmi-vm-test-run-sudo

@globin globin merged commit 4598114 into NixOS:master Oct 21, 2018
@globin globin deleted the remove-old-wrapper-upgrade-code branch October 21, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @GrahamcOfBorg @globin