Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel: support shellHook when defining kernel #48616

Closed
wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Oct 17, 2018

So that

  pkg = linuxManualConfig {
    inherit stdenv;
    inherit (linux_mptcp_94) src version modDirVersion;

    # we need this to true else the kernel can't parse the config and
    # detect if modules are in used
    allowImportFromDerivation = true;

    shellHook = ''
      touch .scmversion
      echo "hello boss"
    '';
  };

works for instance.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

So that
```
  pkg = linuxManualConfig {
    inherit stdenv;
    inherit (linux_mptcp_94) src version modDirVersion;

    # we need this to true else the kernel can't parse the config and
    # detect if modules are in used
    allowImportFromDerivation = true;

    shellHook = ''
      touch .scmversion
      echo "hello boss"
    '';
  };
```
works for instance.
@teto
Copy link
Member Author

teto commented Oct 17, 2018

or one can use

  }).overrideAttrs (oa: {
    shellHook = ''
      touch .scmversion
      echo "hello boss"
    '';
  })
  ;

closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants