Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic: 0.9.2 -> 0.9.3 #48627

Closed
wants to merge 1 commit into from
Closed

restic: 0.9.2 -> 0.9.3 #48627

wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

restic recently switched to using Go 1.11 modules: restic/restic#1920
I don't know any Go so tried to guess how to do that the right way in Nixpkgs. Please have a look.
Again: I have no idea whether I'm using GO111MODULE and GOCACHE the right way.

All I can say is that restic seems to run fine according to my short test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (new: 17178568, old: 16659688)
  • Fits CONTRIBUTING.md.

cc @adisbladis @Mic92

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: restic

Partial log (click to expand)

shrinking /nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin/bin/restic
cannot find section .dynamic
gzipping man pages under /nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin/bin
patching script interpreter paths in /nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin
checking for references to /build in /nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/j830pg6x4s7rfqva0hawcwqrjd2fzn0s-restic-0.9.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: restic

Partial log (click to expand)

find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
find: '/nix/store/576diakpgzsx94ybj9nf1ml7v3zikdkb-restic-0.9.3': No such file or directory
/nix/store/rkc1z19885g34rs1v9q094zls1nkzyn6-restic-0.9.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: restic

Partial log (click to expand)

shrinking /nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin/bin/restic
cannot find section .dynamic
gzipping man pages under /nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin/bin
patching script interpreter paths in /nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin
checking for references to /build in /nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin...
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/bm2qhc1jcgjn4db61zkzcpylmv3kfwin-restic-0.9.3-bin

Mic92
Mic92 reviewed Oct 21, 2018
View reviewed changes
pkgs/tools/backup/restic/default.nix
buildPhase = ''
cd go/src/${goPackagePath}
go run build.go
GO111MODULE=on GOCACHE=`mktemp -d` go run -mod=vendor build.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we already set GOCACHE = "off", but this does not work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm getting either build flag -mod=vendor only valid when using modules or go: cannot use modules with build cache disabled if I I also remove -mod=vendor. It also doesn't work if I remove GO111MODULE=on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could detect go modules automatically.

@NixOS NixOS deleted a comment from dotlambda Oct 22, 2018
@NixOS NixOS deleted a comment from dotlambda Oct 22, 2018
@NixOS NixOS deleted a comment from dotlambda Oct 22, 2018
@eliasp
Copy link
Member

eliasp commented Jan 6, 2019

FYI: restic-0.9.4 was just released:

@xeji xeji mentioned this pull request Feb 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @GrahamcOfBorg @eliasp @Mic92 @roberth