Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: 5.2.4 -> 5.3.1 #48631

Merged
merged 1 commit into from Oct 18, 2018
Merged

grafana: 5.2.4 -> 5.3.1 #48631

merged 1 commit into from Oct 18, 2018

Conversation

WilliButz
Copy link
Member

Motivation for this change

Latest Release with bugfixes and a few new features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.grafana

Partial log (click to expand)

cannot build derivation '/nix/store/fdpl2aplqng1hjy27138c448f32hynw9-system-units.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/5fdmy96998692mnskpklv4nmaljqqq9i-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/skcr0isq480nyi2ahirfbhyq6r5pjh4j-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/i269f1kbn8x05kb8rif1dz9mismx8xqd-nixos-system-machine-19.03.git.ab919ae.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/92ykik2hkjprn5dfjymiqddqfvjjxw9w-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gd8f5fz064byi824gy8y61d5lzc4ph9r-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hy11rcsd7nygp5vpqzcfsgr0h9a7j6ss-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/i71fmsgq68a4b809c7ajxy5pr2xkh50v-nixos-test-driver-grafana.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sbrnip715bjzwhqn7jn708gfn8h1znhp-vm-test-run-grafana.drv': 1 dependencies couldn't be built
error: build of '/nix/store/sbrnip715bjzwhqn7jn708gfn8h1znhp-vm-test-run-grafana.drv' failed

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018

@GrahamcOfBorg build grafana

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: grafana

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2018 •
edited

The regression on aarch64 is just resource depletion due too many parallel builds.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: grafana

Partial log (click to expand)

github.com/grafana/grafana/pkg/setting
github.com/grafana/grafana/vendor/github.com/go-macaron/session/memcache
github.com/grafana/grafana/pkg/components/securejsondata
github.com/grafana/grafana/vendor/github.com/go-macaron/session/redis
github.com/grafana/grafana/vendor/github.com/prometheus/client_model/go
github.com/grafana/grafana/vendor/github.com/matttproud/golang_protobuf_extensions/pbutil
github.com/grafana/grafana/vendor/github.com/prometheus/common/expfmt
github.com/grafana/grafana/vendor/github.com/prometheus/client_golang/prometheus
builder for '/nix/store/ig9kqq3vw61g51ajfz0g0xhfww3fy7qi-grafana-5.3.1.drv' failed with exit code 51
error: build of '/nix/store/ig9kqq3vw61g51ajfz0g0xhfww3fy7qi-grafana-5.3.1.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: grafana

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grafana

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/grafana-cli
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/build
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/grafana-server
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/release_publisher
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin
patching script interpreter paths in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin
checking for references to /build in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: grafana

Partial log (click to expand)

github.com/grafana/grafana/vendor/github.com/grafana/grafana-plugin-model/go/datasource
github.com/grafana/grafana/pkg/plugins/datasource/wrapper
github.com/grafana/grafana/pkg/services/sqlstore/migrator
github.com/grafana/grafana/pkg/services/search
github.com/grafana/grafana/pkg/services/dashboards
github.com/grafana/grafana/pkg/plugins
github.com/grafana/grafana/pkg/api/pluginproxy
github.com/grafana/grafana/pkg/tsdb/stackdriver
builder for '/nix/store/ig9kqq3vw61g51ajfz0g0xhfww3fy7qi-grafana-5.3.1.drv' failed with exit code 44
error: build of '/nix/store/ig9kqq3vw61g51ajfz0g0xhfww3fy7qi-grafana-5.3.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grafana

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/build
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/grafana-cli
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/grafana-server
shrinking /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin/release_publisher
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin/bin
patching script interpreter paths in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin
checking for references to /build in /nix/store/ha549n19gpig4w0y7i2ynly2qhi42n4l-grafana-5.3.1-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.grafana

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 25.24s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ldlgf4zy6ghc1manhcr5i5597my643j7-vm-test-run-grafana

@lheckemann
Copy link
Member

Rerunning the test manually on the community box, will merge if it succeeds :)

@lheckemann
Copy link
Member

It fails consistently when run manually, I don't think what @Mic92 said is correct. I'll check if it's a regression and merge if not :)

@Mic92
Copy link
Member

Mic92 commented Oct 18, 2018

@lheckemann Have you tried to reduce the number of cores when building?

@lheckemann
Copy link
Member

The grafana test runs fine on nixos-unstable.

@lheckemann
Copy link
Member

Huh, but it does work fine with this PR with fewer cores? How odd. But I guess it's good to merge.

@lheckemann lheckemann merged commit 9fa59b6 into NixOS:master Oct 18, 2018
@lheckemann lheckemann deleted the grafana-update branch October 18, 2018 08:07
@Mic92
Copy link
Member

Mic92 commented Oct 18, 2018

@lheckemann we hit some resource limit when having more cores on that machine:

runtime: failed to create new OS thread (have 12 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Either memory or some process limit. I have seen this frequently on the aarch64 builder for go compilation.

@lheckemann
Copy link
Member

errno 11 is EAGAIN, according to clone(2) it returns this when "Too many processes are already running; see fork(2)." fork(2):

EAGAIN A system-imposed limit on the number of threads was encountered. There are a number of limits that may trigger this error:

  • the RLIMIT_NPROC soft resource limit (set via setrlimit(2)), which limits the number of processes and threads for a real user ID, was reached;

  • the kernel's system-wide limit on the number of processes and threads, /proc/sys/kernel/threads-max, was reached (see proc(5));

  • the maximum number of PIDs, /proc/sys/kernel/pid_max, was reached (see proc(5)); or

  • the PID limit (pids.max) imposed by the cgroup "process number" (PIDs) controller was reached.

I'm not sure which of these is the case. All these limits look pretty generous to me (including inside a nix build), except the cgroup one which I don't know how to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilliButz @GrahamcOfBorg @Mic92 @lheckemann