coq: add ocamlPackages in passthru #48617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might need OCaml packages that are not the one Coq is depending on but they still need to come from the same package set (same OCaml version).
vbgl
reviewed
Oct 18, 2018
| @@ -37,6 +37,8 @@ self = stdenv.mkDerivation { | |||
|
|
|||
| passthru = { | |||
| inherit coq-version; | |||
| inherit ocamlPackages; | |||
| # For compatibility | |||
| inherit (ocamlPackages) ocaml camlp5 findlib num; | |||
There was a problem hiding this comment.
Please do the corresponding cleaning in the various coq packages. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some package depending on Coq might need OCaml packages that are not the ones Coq is depending on but they still need to come from the same package set (same OCaml version).
Mitigates coq/coq#8227 (in Coq's
default.nixwe have onlyocamlPackagesas a passthru attribute, notocaml,camlp5,findlibandnum).Things done
I only tested that the expression is evaluated correctly.
cc @vbgl