Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mytetra: support opening urls under wayland #48641

Merged
merged 1 commit into from Oct 24, 2018
Merged

mytetra: support opening urls under wayland #48641

merged 1 commit into from Oct 24, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2018

Motivation for this change

xdg_utils is not available in case of wayland setup, so wrap mytetra with xdg_utils in path in order to add support of opening urls under wayland

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 24, 2018

@GrahamcOfBorg build mytetra

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mytetra

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27
shrinking /nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27/bin/mytetra
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27/bin
patching script interpreter paths in /nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27
checking for references to /build in /nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27...
postPatchMkspecs
postPatchMkspecs
/nix/store/3nmyjh4fs4lyn589lm6qk9pxpiw8npf1-mytetra-1.43.27

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mytetra

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27
shrinking /nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27/bin/mytetra
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27/bin
patching script interpreter paths in /nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27
checking for references to /build in /nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27...
postPatchMkspecs
postPatchMkspecs
/nix/store/481qgwn5pjksq6j1cvj7f8nlysalxnsm-mytetra-1.43.27

@xeji xeji merged commit 782c820 into NixOS:master Oct 24, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mytetra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@ghost
Copy link
Author

ghost commented Oct 24, 2018

@xeji Thanks!

@ghost ghost deleted the mytetra branch October 24, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg