Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler: 1.16.3 -> 1.16.6 #48629

Merged
merged 1 commit into from Oct 17, 2018
Merged

bundler: 1.16.3 -> 1.16.6 #48629

merged 1 commit into from Oct 17, 2018

Conversation

alyssais
Copy link
Member

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Oct 17, 2018

thanks! It looks like 1.16.6 is already out, do you mind bumping the PR?
https://github.com/bundler/bundler/blob/1-16-stable/CHANGELOG.md

@alyssais
Copy link
Member Author

Wow they're moving quickly! Will do

@alyssais
Copy link
Member Author

Done :)

@alyssais alyssais changed the title bundler: 1.16.3 -> 1.16.4 bundler: 1.16.3 -> 1.16.6 Oct 17, 2018
@zimbatm
Copy link
Member

zimbatm commented Oct 17, 2018

@GrahamcOfBorg build bundler

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bundler

Partial log (click to expand)

installing
buildFlags:
WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/8js19lp54zd1b6rx69y8val6cs9z8l9q-bundler-1.16.4/lib/ruby/gems/2.5.0/bin
  Gem home: /nix/store/8js19lp54zd1b6rx69y8val6cs9z8l9q-bundler-1.16.4/lib/ruby/gems/2.5.0
Successfully installed bundler-1.16.4
1 gem installed
post-installation fixup
/nix/store/8js19lp54zd1b6rx69y8val6cs9z8l9q-bundler-1.16.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bundler

Partial log (click to expand)

WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/q2bdrj281cvbvgcy4yxr3lbfwyrq4w0g-bundler-1.16.4/lib/ruby/gems/2.5.0/bin
  Gem home: /nix/store/q2bdrj281cvbvgcy4yxr3lbfwyrq4w0g-bundler-1.16.4/lib/ruby/gems/2.5.0
Successfully installed bundler-1.16.4
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q2bdrj281cvbvgcy4yxr3lbfwyrq4w0g-bundler-1.16.4
checking for references to /build in /nix/store/q2bdrj281cvbvgcy4yxr3lbfwyrq4w0g-bundler-1.16.4...
/nix/store/q2bdrj281cvbvgcy4yxr3lbfwyrq4w0g-bundler-1.16.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bundler

Partial log (click to expand)

WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/0058clgzm5zigl6jax0xlf6mq8pp97rk-bundler-1.16.4/lib/ruby/gems/2.5.0/bin
  Gem home: /nix/store/0058clgzm5zigl6jax0xlf6mq8pp97rk-bundler-1.16.4/lib/ruby/gems/2.5.0
Successfully installed bundler-1.16.4
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0058clgzm5zigl6jax0xlf6mq8pp97rk-bundler-1.16.4
checking for references to /build in /nix/store/0058clgzm5zigl6jax0xlf6mq8pp97rk-bundler-1.16.4...
/nix/store/0058clgzm5zigl6jax0xlf6mq8pp97rk-bundler-1.16.4

@zimbatm
Copy link
Member

zimbatm commented Oct 17, 2018

Thanks @alyssais

You have been doing good ruby contributions over time. If you want ofborg to auto-build your PR, make a PR to the ofborg repo like NixOS/ofborg#252 and I will +1 you.

@zimbatm zimbatm merged commit 11763c5 into NixOS:master Oct 17, 2018
@zimbatm
Copy link
Member

zimbatm commented Oct 17, 2018

If you're interested, make sure to read the README to understand how it works first

@alyssais alyssais mentioned this pull request Oct 17, 2018
Merged
@alyssais alyssais deleted the bundler branch November 2, 2018 11:22
@ryantm
Copy link
Member

ryantm commented Nov 15, 2018

@zimbatm @alyssais It looks like this got merged as just upgrading bundler to 1.16.4

@alyssais
Copy link
Member Author

We're up to 1.17.1 now anyway, looks like. https://rubygems.org/gems/bundler

@alyssais
Copy link
Member Author

alyssais commented Nov 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @zimbatm @GrahamcOfBorg @ryantm