Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostapd's place in systemd dependency tree. (#45464) #48632

Merged
merged 1 commit into from Oct 17, 2018

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 17, 2018

(cherry picked from commit 725fcde)

  • nat/bind/dhcp.service:
    Remove. Those services have nothing to do with a link-level service.

  • sys-subsystem-net-devices-${if}.device:
    Add as BindsTo dependency as this will make hostapd stop when the
    device is unplugged.

  • network-link-${if}.service:
    Add hostapd as dependency for this service via requiredBy clause,
    so that the network link is only considered to be established
    only after hostapd has started.

  • network.target:
    Remove this from wantedBy clause as this is already implied from
    dependencies stacked above hostapd. And if it's not implied than
    starting hostapd is not required for this particular network
    configuration.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

* nat/bind/dhcp.service:
  Remove. Those services have nothing to do with a link-level service.

* sys-subsystem-net-devices-${if}.device:
  Add as BindsTo dependency as this will make hostapd stop when the
  device is unplugged.

* network-link-${if}.service:
  Add hostapd as dependency for this service via requiredBy clause,
  so that the network link is only considered to be established
  only after hostapd has started.

* network.target:
  Remove this from wantedBy clause as this is already implied from
  dependencies stacked above hostapd. And if it's not implied than
  starting hostapd is not required for this particular network
  configuration.

(cherry picked from commit 725fcde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants