Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalafix: init at 0.9.0 #49056

Merged
merged 1 commit into from Oct 28, 2018
Merged

scalafix: init at 0.9.0 #49056

merged 1 commit into from Oct 28, 2018

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Oct 24, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

meta = with stdenv.lib; {
description = "Refactoring and linting tool for Scala";
homepage = https://scalacenter.github.io/scalafix/;
license = licenses.asl20;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github repo seems to have a BSD license instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're completely right.

@roberth roberth merged commit 1575950 into NixOS:master Oct 28, 2018
@roberth
Copy link
Member

roberth commented Oct 28, 2018

Thanks!

@Tomahna Tomahna deleted the scalafix branch October 28, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants