Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r8168 backport #48984

Merged
merged 1 commit into from Oct 25, 2018
Merged

r8168 backport #48984

merged 1 commit into from Oct 25, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 24, 2018 •
edited

Motivation for this change

Backport of #48921.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
r8168: init at 8.046.00
8e9b654 
(cherry picked from commit c8b5dea)
@timokau timokau requested a review from samueldr October 24, 2018 09:52
@Mic92
Copy link
Member

Mic92 commented Oct 24, 2018

@GrahamcOfBorg build linuxPackages.r8168

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.r8168

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14004:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14004:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14313:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14313:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxPackages.r8168

Partial log (click to expand)

  LD [M]  /build/source/src/r8168.ko
make: Leaving directory '/nix/store/qxx4qya1ah29a9y0b11cckcy9zfs491j-linux-4.14.78-dev/lib/modules/4.14.78/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2fjr455ns8mxy8bacm5zsffqdlxrhfyg-r8168-4.14.78-8.046.00
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2fjr455ns8mxy8bacm5zsffqdlxrhfyg-r8168-4.14.78-8.046.00/lib
patching script interpreter paths in /nix/store/2fjr455ns8mxy8bacm5zsffqdlxrhfyg-r8168-4.14.78-8.046.00
checking for references to /build in /nix/store/2fjr455ns8mxy8bacm5zsffqdlxrhfyg-r8168-4.14.78-8.046.00...
/nix/store/2fjr455ns8mxy8bacm5zsffqdlxrhfyg-r8168-4.14.78-8.046.00

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages.r8168

Partial log (click to expand)

  LD [M]  /build/source/src/r8168.ko
make: Leaving directory '/nix/store/13r1dybm9f1xz0bl2s33qqi36cypbxzd-linux-4.14.78-dev/lib/modules/4.14.78/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/50g0v566pfzkikpcxb1ffwi925sb32mf-r8168-4.14.78-8.046.00
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/50g0v566pfzkikpcxb1ffwi925sb32mf-r8168-4.14.78-8.046.00/lib
patching script interpreter paths in /nix/store/50g0v566pfzkikpcxb1ffwi925sb32mf-r8168-4.14.78-8.046.00
checking for references to /build in /nix/store/50g0v566pfzkikpcxb1ffwi925sb32mf-r8168-4.14.78-8.046.00...
/nix/store/50g0v566pfzkikpcxb1ffwi925sb32mf-r8168-4.14.78-8.046.00

@Mic92 Mic92 merged commit 21cf1c4 into NixOS:release-18.09 Oct 25, 2018
@timokau timokau deleted the r8168-backport branch October 25, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @Mic92 @GrahamcOfBorg