homely: init at 0.15.3 #49054

lokke-me · 2018-10-24T17:02:35Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

srhb · 2018-10-25T06:41:25Z

pkgs/applications/misc/homely/default.nix

@@ -0,0 +1,29 @@
+{
+  stdenv


Please format as either

{ stdenv , pythonPackages }:

or

{ stdenv, pythonPackages }:

srhb · 2018-10-25T06:41:58Z

pkgs/applications/misc/homely/default.nix

+
+  buildInputs = with pythonPackages; [ attrs setuptools_scm ];
+  propagatedBuildInputs = with pythonPackages; [
+                        requests


Please indent these using two spaces, like in the rest of the expression.

srhb · 2018-10-25T06:44:34Z

@GrahamcOfBorg build homely

srhb · 2018-10-25T06:44:52Z

----------------------------------------------------------------------
Ran 0 tests in 0.000s

Looks like there are no tests, so please add doCheck = false; as well. :)

GrahamcOfBorg · 2018-10-25T06:44:54Z

Success on aarch64-linux (full log)

Attempted: homely

Partial log (click to expand)

writing entry points to homely.egg-info/entry_points.txt
reading manifest file 'homely.egg-info/SOURCES.txt'
writing manifest file 'homely.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/yj3q9789ni1kszm37r9hbp84rwi4n0pm-homely-0.15.3

GrahamcOfBorg · 2018-10-25T06:45:26Z

Success on x86_64-darwin (full log)

Attempted: homely

Partial log (click to expand)

writing entry points to homely.egg-info/entry_points.txt
reading manifest file 'homely.egg-info/SOURCES.txt'
writing manifest file 'homely.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/kds9cahjk7wx5w53x21dqrsbk8pkc30f-homely-0.15.3

GrahamcOfBorg · 2018-10-25T06:45:43Z

Success on x86_64-linux (full log)

Attempted: homely

Partial log (click to expand)

writing entry points to homely.egg-info/entry_points.txt
reading manifest file 'homely.egg-info/SOURCES.txt'
writing manifest file 'homely.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/nv7s43dpgm9yqrbf86c71wicas28ccl7-homely-0.15.3

lokke-me · 2018-10-25T16:45:31Z

I fixed the mentioned issues, thanks for the feedback

infinisil · 2018-10-26T23:46:15Z

pkgs/applications/misc/homely/default.nix

+    pythondaemon
+  ];
+
+  doCheck = false;


Also works with this removed

infinisil · 2018-11-10T14:10:41Z

Ping? Will merge if you fix above issue

infinisil · 2018-11-11T21:11:27Z

Oh haha, I just now realized that @srhb said to add doCheck = false; and I said to remove it again.

@srhb I think it's better to make it try to run tests anyways, even if there aren't any, because future versions of the package might do have them.

lokke-me · 2018-11-12T21:23:31Z

I fixed the bad rebase. What about the doCheck = false; option?

Mic92 · 2018-11-14T17:19:44Z

@srhb asked you to add doCheck = false; to the package since we run by default tests for python packages. There are no tests included in the python package. The github release would include tests, but at least some of those require network access: https://github.com/phodge/homely/blob/master/test/test_gitvcs.py

Ekleog · 2019-03-26T23:04:44Z

@lokke-me Sorry for the delay! Could you just rebase your PR on latest master (basically just putting your block in maintainer-list.nix at the right alphabetical location), so that I could trigger a final ofborg run and merge? Feel free to poke me if I don't do in the next few days, or there's a risk that this slips under the radar again :/

stale · 2020-06-02T02:48:11Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

pkgs/applications/misc/homely/default.nix

Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>

Mic92 · 2020-06-02T12:08:36Z

pkgs/top-level/all-packages.nix

@@ -17273,6 +17273,8 @@ with pkgs;

  hovercraft = python3Packages.callPackage ../applications/misc/hovercraft { };

+  homely = callPackage ../applications/misc/homely {};


Suggested change

homely = callPackage ../applications/misc/homely {};

homely = python3Packages.callPackage ../applications/misc/homely {};

Mic92 · 2020-06-02T12:09:12Z

pkgs/applications/misc/homely/default.nix

@@ -0,0 +1,26 @@
+{ stdenv, pythonPackages }:


And than we can list all python modules here explicit instead of pythonPackages.

As a concrete GitHub suggestion,

Suggested change

{ stdenv, pythonPackages }:

{ stdenv

, buildPythonApplication

, fetchPypi

, attrs

, setuptools_scm

, requests

, simplejson

, click

, pythondaemon

}:

buildPythonApplication rec {

version = "0.15.3";

pname = "homely";

src = fetchPypi {

inherit pname version;

sha256 = "2aa7461b583660bf8d9ad776c184fa7a1272141a5c0faaf78a76bc3e8c39db6d";

};

buildInputs = [ attrs setuptools_scm ];

propagatedBuildInputs = [

requests

simplejson

click

pythondaemon

];

lukegb · 2020-11-25T15:23:02Z

Result of nixpkgs-review pr 49054 1

lukegb · 2020-11-25T15:25:10Z

Result of nixpkgs-review pr 49054 1

lukegb

Builds and runs for me. Upstream has released 0.16 in the meantime (sorry).

As written, this derivation uses Python 2, which is undesirable, but if you take Mic92 and my suggestions then this should be good-to-go.

lukegb · 2020-11-25T15:21:05Z

pkgs/applications/misc/homely/default.nix

@@ -0,0 +1,26 @@
+{ stdenv, pythonPackages }:


As a concrete GitHub suggestion,

Suggested change

{ stdenv, pythonPackages }:

{ stdenv

, buildPythonApplication

, fetchPypi

, attrs

, setuptools_scm

, requests

, simplejson

, click

, pythondaemon

}:

buildPythonApplication rec {

version = "0.15.3";

pname = "homely";

src = fetchPypi {

inherit pname version;

sha256 = "2aa7461b583660bf8d9ad776c184fa7a1272141a5c0faaf78a76bc3e8c39db6d";

};

buildInputs = [ attrs setuptools_scm ];

propagatedBuildInputs = [

requests

simplejson

click

pythondaemon

];

lukegb · 2020-11-25T15:28:11Z

pkgs/applications/misc/homely/default.nix

+    sha256 = "2aa7461b583660bf8d9ad776c184fa7a1272141a5c0faaf78a76bc3e8c39db6d";
+  };
+
+  buildInputs = with pythonPackages; [ attrs setuptools_scm ];


Is attrs required? I tried removing it (with Mic92's suggestion) and the package built fine.

Mic92 · 2020-11-25T18:52:26Z

I think the author lost interest for this one. Maybe someone else could make a PR if they are interested.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 24, 2018

srhb requested changes Oct 25, 2018

View reviewed changes

infinisil requested changes Oct 26, 2018

View reviewed changes

pkgs/applications/misc/homely/default.nix Outdated

pythondaemon

];

doCheck = false;

Copy link

Member

infinisil Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works with this removed

GrahamcOfBorg added the 2.status: merge conflict label Nov 11, 2018

lokke-me requested review from basvandijk, edolstra, edwtjo, Ericson2314, FRidh, LnL7, matthewbauer, Mic92, nbp, peti, Profpatsch, ryantm, thoughtpolice, ttuegel and zimbatm as code owners November 11, 2018 18:27

GrahamcOfBorg removed the 2.status: merge conflict label Nov 11, 2018

Mic92 removed request for ryantm, matthewbauer, peti, edwtjo, Mic92, ttuegel, basvandijk, LnL7, Ericson2314, edolstra, nbp, FRidh and Profpatsch November 12, 2018 10:11

homely: init at 0.15.3

0533570

lokke-me force-pushed the homely branch from 755c3d4 to 0533570 Compare November 12, 2018 21:18

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020

Mic92 reviewed Jun 2, 2020

View reviewed changes

pkgs/applications/misc/homely/default.nix Outdated Show resolved Hide resolved

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020

Update pkgs/applications/misc/homely/default.nix

d2b96b1

Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>

Mic92 reviewed Jun 2, 2020

View reviewed changes

lukegb requested changes Nov 25, 2020

View reviewed changes

Mic92 closed this Nov 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

homely: init at 0.15.3 #49054

homely: init at 0.15.3 #49054

lokke-me commented Oct 24, 2018

srhb Oct 25, 2018

srhb Oct 25, 2018

srhb commented Oct 25, 2018

srhb commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

lokke-me commented Oct 25, 2018

infinisil Oct 26, 2018

infinisil commented Nov 10, 2018

infinisil commented Nov 11, 2018

lokke-me commented Nov 12, 2018

Mic92 commented Nov 14, 2018

Ekleog commented Mar 26, 2019 •

edited

stale bot commented Jun 2, 2020

Mic92 Jun 2, 2020

Mic92 Jun 2, 2020

lukegb Nov 25, 2020

lukegb commented Nov 25, 2020

lukegb commented Nov 25, 2020

lukegb left a comment

lukegb Nov 25, 2020

lukegb Nov 25, 2020

Mic92 commented Nov 25, 2020

		@@ -17273,6 +17273,8 @@ with pkgs;

		hovercraft = python3Packages.callPackage ../applications/misc/hovercraft { };

		homely = callPackage ../applications/misc/homely {};

	homely = callPackage ../applications/misc/homely {};
	homely = python3Packages.callPackage ../applications/misc/homely {};

-{ stdenv, pythonPackages }:
+{ stdenv
+, buildPythonApplication
+, fetchPypi
+, attrs
+, setuptools_scm
+, requests
+, simplejson
+, click
+, pythondaemon
+}:
+buildPythonApplication rec {
+  version = "0.15.3";
+  pname = "homely";
+  src = fetchPypi {
+    inherit pname version;
+    sha256 = "2aa7461b583660bf8d9ad776c184fa7a1272141a5c0faaf78a76bc3e8c39db6d";
+  };
+  buildInputs = [ attrs setuptools_scm ];
+  propagatedBuildInputs = [
+    requests
+    simplejson
+    click
+    pythondaemon
+  ];

homely: init at 0.15.3 #49054

homely: init at 0.15.3 #49054

Conversation

lokke-me commented Oct 24, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srhb commented Oct 25, 2018

srhb commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

lokke-me commented Oct 25, 2018

Choose a reason for hiding this comment

infinisil commented Nov 10, 2018

infinisil commented Nov 11, 2018

lokke-me commented Nov 12, 2018

Mic92 commented Nov 14, 2018

Ekleog commented Mar 26, 2019 • edited

stale bot commented Jun 2, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukegb commented Nov 25, 2020

lukegb commented Nov 25, 2020

lukegb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 commented Nov 25, 2020

Ekleog commented Mar 26, 2019 •

edited