Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmrconfig: init at 2018-10-20 #49052

Merged
merged 1 commit into from Oct 26, 2018
Merged

dmrconfig: init at 2018-10-20 #49052

merged 1 commit into from Oct 26, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 24, 2018

Motivation for this change

dmrconfig is a util to configure a bunch of hamradio's for digital mode radio usage

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dmrconfig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

install flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash install
install -c -s dmrconfig /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20
shrinking /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20/bin/dmrconfig
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20/bin
patching script interpreter paths in /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20
checking for references to /build in /nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20...
/nix/store/4khyx6i525wyi4yy333s7qmaj4s3w3ds-dmrconfig-2018-10-20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash install
install -c -s dmrconfig /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20
shrinking /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20/bin/dmrconfig
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20/bin
patching script interpreter paths in /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20
checking for references to /build in /nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20...
/nix/store/h0qfidxf8j23rn00ydr198mbdggcf0pv-dmrconfig-2018-10-20

adisbladis
adisbladis requested changes Oct 26, 2018
View reviewed changes
pkgs/applications/misc/dmrconfig/default.nix Outdated
];

preConfigure = ''
substituteInPlace Makefile \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why so much white space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, because it's pretty? 😄

I'll change it.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dmrconfig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

install flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash install
install -c -s dmrconfig /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20
shrinking /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20/bin/dmrconfig
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20/bin
patching script interpreter paths in /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20
checking for references to /build in /nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20...
/nix/store/iyywsa0x085qwgmnyz63p7pip8jql6sa-dmrconfig-2018-10-20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash install
install -c -s dmrconfig /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20
shrinking /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20/bin/dmrconfig
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20/bin
patching script interpreter paths in /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20
checking for references to /build in /nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20...
/nix/store/s6f8xlhnwk12x9zzfsmawpqnqjjvyvpy-dmrconfig-2018-10-20

@adisbladis adisbladis merged commit 1a1aa4d into NixOS:master Oct 26, 2018
@etu etu mentioned this pull request Oct 27, 2018
Closed
@etu etu deleted the init-dmrconfig branch October 29, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @adisbladis