Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure functions core tools #48453

Merged
merged 1 commit into from Nov 6, 2018
Merged

Azure functions core tools #48453

merged 1 commit into from Nov 6, 2018

Conversation

ilikeavocadoes
Copy link
Contributor

Motivation for this change

Add Azure functions core tools to set up local Azure functions development environment using Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ilikeavocadoes ilikeavocadoes changed the base branch from master to release-18.09 October 15, 2018 09:02
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018

Please change the branch to master.

@ilikeavocadoes
Copy link
Contributor Author

Should I also rebase on it?

@zimbatm
Copy link
Member

zimbatm commented Oct 15, 2018

yes please!

@ilikeavocadoes
Copy link
Contributor Author

Is there still something that needs to be done?

@zimbatm
Copy link
Member

zimbatm commented Nov 3, 2018

sorry it needs a rebase again. please ping me when it's done so I can review and merge right after

@ilikeavocadoes
Copy link
Contributor Author

@zimbatm I rebased it on master. Hope it's all right now.

@zimbatm zimbatm merged commit dfa5a2b into NixOS:master Nov 6, 2018
@zimbatm
Copy link
Member

zimbatm commented Nov 6, 2018

thanks!

@ilikeavocadoes ilikeavocadoes deleted the azure-functions-core-tools branch November 6, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilikeavocadoes @Mic92 @zimbatm @GrahamcOfBorg @Janik-Haag