Skip to content

Azure functions core tools #48453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

Azure functions core tools #48453

merged 1 commit into from
Nov 6, 2018
+2,236 −2,022

Conversation

ilikeavocadoes
Copy link
Contributor

Motivation for this change

Add Azure functions core tools to set up local Azure functions development environment using Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ilikeavocadoes ilikeavocadoes changed the base branch from master to release-18.09 October 15, 2018 09:02
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Oct 15, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018

Please change the branch to master.

@ilikeavocadoes
Copy link
Contributor Author

Should I also rebase on it?

@GrahamcOfBorg GrahamcOfBorg removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 15, 2018
@zimbatm
Copy link
Member

zimbatm commented Oct 15, 2018

yes please!

@Mic92 Mic92 removed request for LnL7, Mic92, rycee and zimbatm October 15, 2018 19:03
@ilikeavocadoes
Copy link
Contributor Author

Is there still something that needs to be done?

@zimbatm
Copy link
Member

zimbatm commented Nov 3, 2018

sorry it needs a rebase again. please ping me when it's done so I can review and merge right after

nodePackages: add azure-functions-core-tools

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
9ba8cdb
@ilikeavocadoes ilikeavocadoes force-pushed the azure-functions-core-tools branch from 116cd2d to 9ba8cdb Compare November 5, 2018 07:51
@ilikeavocadoes
Copy link
Contributor Author

@zimbatm I rebased it on master. Hope it's all right now.

@zimbatm zimbatm merged commit dfa5a2b into NixOS:master Nov 6, 2018
@zimbatm
Copy link
Member

zimbatm commented Nov 6, 2018

thanks!

@ilikeavocadoes ilikeavocadoes deleted the azure-functions-core-tools branch November 6, 2018 07:10
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilikeavocadoes @Mic92 @zimbatm @GrahamcOfBorg @Janik-Haag