-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geoclue2: 2.4.12 -> 2.5.1 #48438
geoclue2: 2.4.12 -> 2.5.1 #48438
Conversation
Failure on aarch64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
2.5.1 is out. |
d6454e7
to
a2d7bac
Compare
Failure on x86_64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
a2d7bac
to
d7e264e
Compare
meson has been upgraded to 0.48.2 in staging, so this should be clear now. cc @jtojnar |
I would still wait a while to make sure it sticks. |
Success on aarch64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
d7e264e
to
466c27c
Compare
I've added |
466c27c
to
607aefd
Compare
Success on aarch64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: geoclue2 Partial log (click to expand)
|
@jtojnar I saw you changed the base branch to master. It's fine to merge there correct? |
#45306 is now relevant |
Note that in recent versions they've dropped the agent requirement for "system" apps, so we can potentially drop that whole annoyance and just go back to modifying the config file. |
You just put "system" in the config file, I can't remember the exact syntax. |
Oops, deleted my comment instead of editing 😄 |
I think we'll still need to generate this https://gitlab.freedesktop.org/geoclue/geoclue/blob/master/data/geoclue.conf.in#L110 |
Yeah, we still need the config file, but we can get rid of the agent. At least I think so! |
Motivation for this change
An update.
Needs newer meson in #45950
I have tested that it builds with that branch.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)