Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapid-photo-downloader: 0.9.10 -> 0.9.12 #48457

Merged
merged 2 commits into from Oct 15, 2018
Merged

rapid-photo-downloader: 0.9.10 -> 0.9.12 #48457

merged 2 commits into from Oct 15, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update and fix dependency pymediainfo as mentioned in #36621.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @orivej

@Mic92 Mic92 merged commit faf3bf3 into NixOS:master Oct 15, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018

Does this need a backport?

@jfrankenau jfrankenau deleted the update-rapid branch October 16, 2018 15:17
@jfrankenau
Copy link
Member Author

No, because 18.09 still uses libmediainfo 18.05 which works fine with pymediainfo 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @Mic92 @GrahamcOfBorg