Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11vnc: 0.9.13 -> 0.9.15 #48459

Merged
merged 0 commits into from Oct 16, 2018
Merged

x11vnc: 0.9.13 -> 0.9.15 #48459

merged 0 commits into from Oct 16, 2018

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 15, 2018 •
edited

(First ever pull request, please forgive me if I do something wrong 🙂)

Motivation for this change

See my issue/request #48263.
tl;dr 0.9.13 is the last release before official development seized from what I can tell. 0.9.15 is a newer community release of x11vnc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
    (There wasn't a maintainer set in meta.maintainers. Should I adopt it? 🤷‍♂️)

@markuskowa
Copy link
Member

@GrahamcOfBorg build x11vnc

markuskowa
markuskowa reviewed Oct 16, 2018
View reviewed changes
pkgs/tools/X11/x11vnc/default.nix Outdated
};

nativeBuildInputs =
[ autoreconfHook pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the line break here (can be written all in one line)

@markuskowa
Copy link
Member

@GrahamcOfBorg build x11vnc

@markuskowa
Copy link
Member

@OPNA2608 Feel free to add yourself as a maintainer if you are willing to look after the package.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: x11vnc

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15
shrinking /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15/bin/x11vnc
gzipping man pages under /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15/bin
patching script interpreter paths in /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15
/nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15/bin/Xdummy: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15...
/nix/store/h9yhsk1hxmi7j8sqy4zldpb44ir3ja7c-x11vnc-0.9.15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: x11vnc

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15
shrinking /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15/bin/x11vnc
gzipping man pages under /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15/bin
patching script interpreter paths in /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15
/nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15/bin/Xdummy: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15...
/nix/store/n2bk13zpal77a51fgkc1wdplr199hiwq-x11vnc-0.9.15

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Oct 16, 2018 •
edited

I think I pushed something wrong, I don't know why it remerged with master and requested more reviewers…

Should I start fresh, recommit and redo the PR? 😕

@markuskowa
Copy link
Member

You can create a new branch after clearing your master then and put your commits on the new branch. Then try to change the branch on GitHub for this PR. If you can't make it work, just open a new PR and ping me.

@OPNA2608 OPNA2608 closed this Oct 16, 2018
@Mic92 Mic92 merged commit aecf926 into NixOS:master Oct 16, 2018
@OPNA2608 OPNA2608 mentioned this pull request Oct 17, 2018
Merged
9 tasks
@markuskowa
Copy link
Member

New PR is #48613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OPNA2608 @markuskowa @GrahamcOfBorg @Mic92 @Janik-Haag