Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix: enable ldap support by default #48458

Merged
merged 1 commit into from Oct 15, 2018
Merged

postfix: enable ldap support by default #48458

merged 1 commit into from Oct 15, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 15, 2018 •
edited

Ldap authentication is fairly common in any reasonable sized mail setup.
Our dovecot also comes with ldap support.
Other distributions like debian, archlinux, ubuntu and fedora also
provide ldap support along with their postfix server.
It might be also useful to have database support, but this is a different pull request.

Our openldap package is 2.6 M big at the moment.

du -sh $buildInputs
2.6M    /nix/store/gbd5aqz9s0r5984dr214g9k1513j4v9i-openldap-2.4.46

We might be able to further reduce this by splitting libraries from slapd.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
postfix: enable openldap by default
c7214bd 
Ldap authentication is fairly common in any reasonable sized mail setup.
Our dovecot also comes with ldap support.
Other distributions like debian, archlinux, ubuntu and fedora also
provide ldap support along with there postfix server.
It might be also useful to have database support, but this is a different pull request.
@Mic92 Mic92 requested a review from fpletz October 15, 2018 12:05
@Mic92 Mic92 changed the title postfix: enable openldap by default postfix: enable ldap support by default Oct 15, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: postfix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postfix

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec  /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/bin  /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/sbin
patching script interpreter paths in /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1
/nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec/postfix/postmulti-script: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec/postfix/.post-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec/postfix/.postfix-script-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec/postfix/postfix-tls-script: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/libexec/postfix/postfix-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1...
moving /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/sbin/* to /nix/store/i942xg2v2mxnayj0y2q01285lcs7xil6-postfix-3.3.1/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: postfix

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec  /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/bin  /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/sbin
patching script interpreter paths in /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1
/nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec/postfix/.postfix-script-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec/postfix/.post-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec/postfix/postmulti-script: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec/postfix/postfix-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/libexec/postfix/postfix-tls-script: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1...
moving /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/sbin/* to /nix/store/dmkz9hsxqwknrg4rl5gsfdc074i8r448-postfix-3.3.1/bin

fpletz
fpletz approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me. We probably already have openldap in most system closures anyway. 👍

@fpletz fpletz merged commit 1a7f99e into NixOS:master Oct 15, 2018
@Mic92 Mic92 deleted the postfix-ldap branch October 15, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @fpletz