Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few python package updates #48452

Merged
merged 2 commits into from Oct 15, 2018
Merged

A few python package updates #48452

merged 2 commits into from Oct 15, 2018

Conversation

joachifm
Copy link
Contributor

Minor updates to python expressions I maintain.

@joachifm joachifm requested a review from FRidh as a code owner October 15, 2018 08:35
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018 

@GrahamcOfBorg build ntfy octoprint python27Packages.emoji python27Packages.jsonrpclib python27Packages.ntfy python36Packages.emoji python36Packages.ntfy

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ntfy, octoprint, python27Packages.emoji, python27Packages.jsonrpclib, python27Packages.ntfy, python36Packages.emoji, python36Packages.ntfy

Partial log (click to expand)

Requirement already satisfied: futures in /nix/store/z6552dkc0xdn88bx99jrybr6cfjjc9l4-python2.7-futures-3.2.0/lib/python2.7/site-packages (from OctoPrint==1.3.8) (3.2.0)
Requirement already satisfied: sarge<0.2,>=0.1.4 in /nix/store/a139yc82dihy55h9l5rdw7ispf03ax2r-python2.7-sarge-0.1.5.post0/lib/python2.7/site-packages (from OctoPrint==1.3.8) (0.1.5.post0)
Requirement already satisfied: PyYAML in /nix/store/yblqkbzcsj7dggdfb1amm0qwbdqsjwsl-python2.7-PyYAML-3.13/lib/python2.7/site-packages (from OctoPrint==1.3.8) (3.13)
Requirement already satisfied: feedparser<5.3,>=5.2.1 in /nix/store/2q0kr33cpkhk3d7w3a8d19mxvgqvfn20-python2.7-feedparser-5.2.1/lib/python2.7/site-packages (from OctoPrint==1.3.8) (5.2.1)
Requirement already satisfied: websocket-client in /nix/store/2vx3gvxxd2yc6jfzxnc6f3hh70i7k6fk-python2.7-websocket_client-0.51.0/lib/python2.7/site-packages (from OctoPrint==1.3.8) (0.51.0)
Collecting appdirs>=1.4.0 (from OctoPrint==1.3.8)
  Could not find a version that satisfies the requirement appdirs>=1.4.0 (from OctoPrint==1.3.8) (from versions: )
No matching distribution found for appdirs>=1.4.0 (from OctoPrint==1.3.8)
builder for '/nix/store/kyqcfspspki76pl3cjjhbhdcpj6iiqgy-OctoPrint-1.3.8.drv' failed with exit code 1
error: build of '/nix/store/kyqcfspspki76pl3cjjhbhdcpj6iiqgy-OctoPrint-1.3.8.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ntfy, octoprint, python27Packages.emoji, python27Packages.jsonrpclib, python27Packages.ntfy, python36Packages.emoji, python36Packages.ntfy

Partial log (click to expand)

Ran 681 tests in 80.290s

OK (SKIP=6)
/nix/store/yzgfb3diyp14grpzwql84axik7zj58jb-python2.7-ntfy-1.2.0
/nix/store/gnpyrbd51v1c74zn050k7z1hvag78vr0-OctoPrint-1.3.8
/nix/store/bhrx8vd01ddfr1hnknf9bqa7x4k6mvl6-python2.7-emoji-0.5.1
/nix/store/fmkxkgh50ccs0am4jzfxjwmfc7v94jdi-python2.7-jsonrpclib-0.1.7
/nix/store/yzgfb3diyp14grpzwql84axik7zj58jb-python2.7-ntfy-1.2.0
/nix/store/mm9ax9mznn2lfqf4v64q1afgqsqixhl2-python3.6-emoji-0.5.1
/nix/store/4nqqxh2filwpds541qzj968jbhnsx530-python3.6-ntfy-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ntfy, octoprint, python27Packages.emoji, python27Packages.jsonrpclib, python27Packages.ntfy, python36Packages.emoji, python36Packages.ntfy

Partial log (click to expand)

Ran 681 tests in 105.293s

OK (SKIP=6)
/nix/store/732rjg9fxz1pr2l4spzgj0856w0mc9lk-python2.7-ntfy-1.2.0
/nix/store/naipr8acjfb1cvx84vzpgix4rsdsnnzy-OctoPrint-1.3.8
/nix/store/r70hgw6mmw3jm40hv28nscd5wm1grxsp-python2.7-emoji-0.5.1
/nix/store/48c68mz7g1pm3v8fq8ggfdh99xkqvmsg-python2.7-jsonrpclib-0.1.7
/nix/store/732rjg9fxz1pr2l4spzgj0856w0mc9lk-python2.7-ntfy-1.2.0
/nix/store/dmv7mdcqr0m7f2qx6faj8vfs2zr49syl-python3.6-emoji-0.5.1
/nix/store/3irfd32iw0iambjncjzr56nlwmwjs3jw-python3.6-ntfy-1.2.0

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018

Has macOS a conditional dependency?

Collecting appdirs>=1.4.0 (from OctoPrint==1.3.8)
  Could not find a version that satisfies the requirement appdirs>=1.4.0 (from OctoPrint==1.3.8) (from versions: )

@joachifm
Copy link
Contributor Author

No idea about octoprint, but this looks like an existing problem with the macos build: https://hydra.nixos.org/build/82721369

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2018 •
edited

Can the package be disabled then on macOS?

bhipple
bhipple reviewed Oct 15, 2018
View reviewed changes
pkgs/top-level/python-packages.nix
maintainers = [ stdenv.lib.maintainers.joachifm ];
};
};
jsonrpclib = callPackage ../development/python-modules/jsonrpclib { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this out of python-packages.nix 👍

@joachifm
Copy link
Contributor Author

@abbradar is listed as the octoprint maintainer, perhaps they know whether it should be disabled on macos.

@joachifm
Copy link
Contributor Author

Merging this, as the octoprint issue seems strictly unrelated.

@joachifm joachifm merged commit 255b642 into NixOS:master Oct 15, 2018
@joachifm joachifm deleted the pythonPackages-bumps-for-upstream branch October 15, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joachifm @Mic92 @GrahamcOfBorg @bhipple